-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse conflict retry loop from client-go/util/retry #1102
Comments
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale I think this is still a good idea to move this feature to a shared place |
This issue is stale because it has been open for 90 days with no |
/remove-lifecycle stale Still a valid improvement to reduce our code footprint. Also, I think this would be a good first issue. |
@rhuss: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
On top of the original proposal. There might be a good enhancement to use the conflict retry loop in other update operations, e.g. sources, triggers, etc. to avoid cases like we see in E2E tests. |
/assign |
Co-authored-by: Martin Gencur <[email protected]>
Instead of our homegrown algorithm for retrying updates in case of a conflict, we should reuse https://github.com/kubernetes/client-go/blob/1eb2027cd51eefaca0f851d5a2c90f8dd9b2a71d/util/retry/util.go#L68-L75 from the kubernetes client lib.
The goal of this refactoring task is to identify the spots where we are doing retries and switch over to this utility method, much like the
kn service import
pr does.The text was updated successfully, but these errors were encountered: