Container names must end with an alphanumeric character #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
knative-prow-robot
added
the
size/S
vdemeester
reviewed
Mar 5, 2019
There was a problem hiding this comment.
@abayer Can we have a test where the name ends with lots of non alpha-numeric ? (and keeping very-long-step-name as is ?
Otherwise, LGTM 😉
|
@vdemeester Ah, you mean one that isn't truncated to end with invalid characters as well? Good call. |
|
@abayer yes 👼 |
abayer
force-pushed
the
valid-characters-at-end-of-container
branch
from
79cdb9b
to
051de9a
Compare
knative-prow-robot
added
size/M
|
@vdemeester Done! |
knative-prow-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abayer, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
My change to prevent overly long step names barfs if it trims down to the last character not being alphanumeric. Oops. Let's fix that.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes
n/a