Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing vhost feature #351

Merged
merged 15 commits into from
Jun 30, 2021
Merged

Testing vhost feature #351

merged 15 commits into from
Jun 30, 2021

Conversation

gabo1208
Copy link
Contributor

Changes

Started RabbitMQ source e2e test file setup
Minor changes to tests, capitalization and RabbitMQ source coverage and documentation

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 24, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 24, 2021
@codecov
Copy link

codecov bot commented Jun 24, 2021 •
edited
Loading

Codecov Report

Merging #351 (ca457aa) into main (004c2d3) will decrease coverage by 2.59%.
The diff coverage is 56.85%.

❗ Current head ca457aa differs from pull request most recent head a055fff. Consider uploading reports for the commit a055fff to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
- Coverage   78.38%   75.78%   -2.60%     
==========================================
  Files          42       44       +2     
  Lines        2475     2767     +292     
==========================================
+ Hits         1940     2097     +157     
- Misses        412      538     +126     
- Partials      123      132       +9
Impacted Files Coverage Δ
pkg/apis/sources/v1alpha1/rabbitmq_types.go 50.00% <ø> (ø)
...kg/reconciler/triggerstandalone/resources/queue.go 80.48% <ø> (+12.48%) ⬆️
pkg/reconciler/trigger/trigger.go 53.09% <7.61%> (-29.87%) ⬇️
pkg/reconciler/triggerstandalone/trigger.go 60.08% <19.71%> (-17.45%) ⬇️
.../reconciler/brokerstandalone/resources/exchange.go 65.85% <50.00%> (-9.76%) ⬇️
pkg/apis/eventing/v1/broker_validation.go 81.48% <81.48%> (ø)
pkg/reconciler/trigger/resources/binding.go 94.80% <94.28%> (-1.20%) ⬇️
.../reconciler/triggerstandalone/resources/binding.go 54.95% <94.44%> (+9.24%) ⬆️
pkg/adapter/adapter.go 65.92% <100.00%> (+11.21%) ⬆️
pkg/rabbitmqnaming/naming.go 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e1ece...a055fff. Read the comment docs.

n3wscott
n3wscott reviewed Jun 28, 2021
View reviewed changes
test/e2e/source_test.go Outdated
@@ -53,3 +55,13 @@ func DirectSourceTest() *feature.Feature {

return f
}

// VhostSourceTest makes sure an RabbitMQ Source is created on the desired vhost.
func VhostSourceTest() *feature.Feature {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: go would have this be called VHostSourceTest

n3wscott
n3wscott reviewed Jun 28, 2021
View reviewed changes
test/e2e/config/sourcevhost/sourcevhost.go Outdated
@@ -0,0 +1,37 @@
/*
Copyright 2020 The Knative Authors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: 2021

n3wscott
n3wscott reviewed Jun 28, 2021
View reviewed changes
test/e2e/config/sourcevhost/rabbitmq-source-vhost.yaml
@@ -0,0 +1,35 @@
apiVersion: sources.knative.dev/v1alpha1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: needs a CR header ^^

@gabo1208 gabo1208 force-pushed the testing-vhost-feature branch from 6d772c0 to 12d66e8 Compare June 29, 2021 15:02
gabo1208 added 14 commits June 29, 2021 16:18
@gabo1208
increased test coverage and created validation base for rabbitmq adapter
10ceb2f
@gabo1208
added basic files to the source vhost e2e test and parelization to vs…
77adb93 
…ource vhost adapter tests
@gabo1208
added yaml to create a source on an specific vhost
9692175
@gabo1208
removed unused validation file and created vhostsource e2e test dir t…
d58fd7d 
…o locate config files
@gabo1208
renamed file for new e2e config test
bcb9f40
@gabo1208
added basic e2e test for vhost in source
c68f4f1
@gabo1208
removed unused label from source yamll
8cc0de7
@gabo1208
fixed context leak in with deadline
7c23b28
@gabo1208
added readme to tests docs
c97f107
@gabo1208
fixed testss
5c7e7f5
@gabo1208
added TODO annotation for rabbitmqsource e2e test
9243ee8
@gabo1208
fixing lint on new readme
ca09b85
@gabo1208
removed unused function calls in tests and added unique name for new …
2bd501c 
…test source yaml
@gabo1208
added CR headders and fixed PR comments
ca457aa
@gabo1208 gabo1208 force-pushed the testing-vhost-feature branch from 12d66e8 to ca457aa Compare June 29, 2021 21:18
n3wscott
n3wscott approved these changes Jun 30, 2021
View reviewed changes
Copy link

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@knative-prow-robot knative-prow-robot merged commit db3e79d into knative-extensions:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n3wscott n3wscott n3wscott approved these changes

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabo1208 @knative-prow-robot @n3wscott