-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added simpledeployment #895
Conversation
Signed-off-by: swastik959 <[email protected]>
Welcome @swastik959! It looks like this is your first PR to knative-extensions/sample-controller 🎉 |
Hi @swastik959. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, swastik959 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #895 +/- ##
=====================================
Coverage 5.77% 5.77%
=====================================
Files 16 16
Lines 225 225
=====================================
Hits 13 13
Misses 212 212 ☔ View full report in Codecov by Sentry. |
Changes
/kind bug
Fixes #487
Release Note
Docs