Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added simpledeployment #895

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

swastik959
Copy link
Contributor

Changes

/kind bug

Fixes #487

Release Note


Docs


Signed-off-by: swastik959 <[email protected]>
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 28, 2024
Copy link

knative-prow bot commented Jun 28, 2024

Welcome @swastik959! It looks like this is your first PR to knative-extensions/sample-controller 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 28, 2024
Copy link

knative-prow bot commented Jun 28, 2024

Hi @swastik959. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from creydr and dsimansk June 28, 2024 14:04
@dprotaso
Copy link
Contributor

dprotaso commented Jul 2, 2024

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 2, 2024
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2024
Copy link

knative-prow bot commented Jul 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, swastik959

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.77%. Comparing base (6595322) to head (a6ad9fc).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #895   +/-   ##
=====================================
  Coverage   5.77%   5.77%           
=====================================
  Files         16      16           
  Lines        225     225           
=====================================
  Hits          13      13           
  Misses       212     212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 16ec5b7 into knative-extensions:main Jul 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook for SimpleDeployment
2 participants