Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP External Auth Support #627

Merged
merged 4 commits into from
Oct 14, 2021
Merged

HTTP External Auth Support #627

merged 4 commits into from
Oct 14, 2021

Conversation

senthilnathan
Copy link
Contributor

Changes

  • Sets ExternalService based on an annotation

/kind enhancement

Fixes #491

@knative-prow-robot knative-prow-robot added kind/enhancement do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 29, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 29, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021 •
edited
Loading

Codecov Report

Merging #627 (8794e1f) into main (d482ace) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #627      +/-   ##
==========================================
+ Coverage   93.63%   93.71%   +0.07%     
==========================================
  Files           7        7              
  Lines         503      509       +6     
==========================================
+ Hits          471      477       +6     
  Misses         15       15              
  Partials       17       17
Impacted Files Coverage Δ
pkg/reconciler/contour/resources/httpproxy.go 97.26% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d482ace...8794e1f. Read the comment docs.

@senthilnathan senthilnathan changed the title [WIP] HTTP External Auth Support HTTP External Auth Support Oct 7, 2021
@knative-prow-robot knative-prow-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2021
@nak3
Copy link
Contributor

nak3 commented Oct 7, 2021

/assign @dprotaso @carlisia

@senthilnathan
Copy link
Contributor Author

/hold
Adding unit tests in a bit.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2021
@knative-prow-robot knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2021
@senthilnathan
Copy link
Contributor Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2021
@senthilnathan
Copy link
Contributor Author

/retest

@dprotaso
Copy link
Contributor

dprotaso commented Oct 7, 2021

This should unblock the tests: #634

@senthilnathan @dprotaso
Using kebab-case for annotations
8794e1f 
Co-authored-by: Dave Protasowski <[email protected]>
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, senthilnathan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021
@senthilnathan
Copy link
Contributor Author

@dprotaso, now that #634 is merged, do I need to rebase this PR to get it merged automatically?

@dprotaso
Copy link
Contributor

dprotaso commented Oct 14, 2021 •
edited
Loading

We're just hitting flakes in our e2e tests -probably the main reason being: #631. But also I've noticed GKE being very flakey

Simply invoking

/retest

will retry the PR again and it will properly merge the latest HEAD when it does

@senthilnathan
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit f934d14 into knative-extensions:main Oct 14, 2021
@senthilnathan senthilnathan deleted the auth branch October 15, 2021 07:03
@dprotaso dprotaso mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

Assignees

@carlisia carlisia

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP Authorization
5 participants
@senthilnathan @nak3 @dprotaso @knative-prow-robot @carlisia