Probing always fails when HTTP fallback is disabled in config-network

[dprotaso]

When HTTP fallback is disabled probing will set an https scheme and a port of 443

https://github.com/knative-sandbox/net-contour/blob/50b263c04bb6ff46398f9a2baa06cd9f13cc0ba3/pkg/reconciler/contour/lister.go#L48-L52

Contour targets Pod IPs for probing which doesn't do TLS termination so the endpoints will never be ready.

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[dprotaso]

/lifecycle frozen

[nak3]

/assign

I will work on this.

[dprotaso]

/unassign @nak3
/assign @kvmware

[dprotaso]

Note this issue changes slightly when #610 lands

Since we'll want to configure the spec.HTTPOption now

[krsna-m]

When using kubectl apply -f https://github.com/knative/net-contour/releases/download/v0.25.0/contour.yaml and kubectl apply -f https://github.com/knative/net-contour/releases/download/v0.25.0/net-contour.yaml a service is created kn service create hello --image gcr.io/knative-samples/helloworld-go --port 8080 --env TARGET=New_World --revision-name=new_world which results in:

$ kubectl get ksvc

NAME    URL                                           LATESTCREATED   LATESTREADY   READY     REASON
hello   https://hello.default.34.71.36.176.sslip.io   hello-world     hello-world   Unknown   EndpointsNotReady

$ kubectl describe ksvc hello

...
Status:
  Address:
    URL:  http://hello.default.svc.cluster.local
  Conditions:
    Last Transition Time:        2021-09-23T19:05:43Z
    Status:                      True
    Type:                        ConfigurationsReady
    Last Transition Time:        2021-09-23T19:05:44Z
    Message:                     Waiting for Envoys to receive Endpoints data.
    Reason:                      EndpointsNotReady
    Status:                      Unknown
    Type:                        Ready
    Last Transition Time:        2021-09-23T19:05:44Z
    Message:                     Waiting for Envoys to receive Endpoints data.
    Reason:                      EndpointsNotReady
    Status:                      Unknown
    Type:                        RoutesReady
  Latest Created Revision Name:  hello-world
  Latest Ready Revision Name:    hello-world
  Observed Generation:           1
  Traffic:
    Latest Revision:  true
    Percent:          100
    Revision Name:    hello-world
  URL:                https://hello.default.34.71.36.176.sslip.io
...

Changing this to use kubectl apply -f https://github.com/knative/net-contour/releases/download/v0.26.0/contour.yaml and kubectl apply -f https://github.com/knative/net-contour/releases/download/v0.26.0/net-contour.yaml which includes the changes from #610 the result is thus:

$ kubectl get ksvc

NAME    URL                                           LATESTCREATED   LATESTREADY   READY     REASON
hello   https://hello.default.34.71.36.176.sslip.io   hello-world     hello-world   True

$ kubectl describe ksvc hello

...
Status:
  Address:
    URL:  http://hello.default.svc.cluster.local
  Conditions:
    Last Transition Time:        2021-09-23T19:05:43Z
    Status:                      True
    Type:                        ConfigurationsReady
    Last Transition Time:        2021-09-23T19:24:51Z
    Status:                      True
    Type:                        Ready
    Last Transition Time:        2021-09-23T19:24:51Z
    Status:                      True
    Type:                        RoutesReady
  Latest Created Revision Name:  hello-world
  Latest Ready Revision Name:    hello-world
  Observed Generation:           1
  Traffic:
    Latest Revision:  true
    Percent:          100
    Revision Name:    hello-world
  URL:                https://hello.default.34.71.36.176.sslip.io
...

$ curl https://hello.default.34.71.36.176.sslip.io

Hello World!

[nak3]

Yes, I believe #610 solved this issue as well. @kvmware Thank you for the confirmation. And I'm sorry if you wanted to tackle this issue 😰

[dprotaso]

/close

…

On Mon, Sep 27, 2021 at 05:31 Kenjiro Nakayama ***@***.***> wrote: Yes, I believe #610 <#610> solved this issue as well. @kvmware <https://github.com/kvmware> Thank you for the confirmation. And I'm sorry if you wanted to tackle this issue 😰 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#423 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAERAWOQXJSRQCVSC5GBFDUEA2X5ANCNFSM4XPGGLHQ> .

[knative-prow-robot]

@dprotaso: Closing this issue.

In response to this:

/close

On Mon, Sep 27, 2021 at 05:31 Kenjiro Nakayama @.***>
wrote:

Yes, I believe #610
#610 solved this
issue as well. @kvmware https://github.com/kvmware Thank you for the
confirmation. And I'm sorry if you wanted to tackle this issue 😰

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#423 (comment),
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAERAWOQXJSRQCVSC5GBFDUEA2X5ANCNFSM4XPGGLHQ
.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.