fix nil pointer dereference when parsing config map (#1096)

Co-authored-by: Izabela Gomes <[email protected]>
knative-extensions · May 23, 2024 · 52fe7b4 · 52fe7b4
1 parent f3bb986
commit 52fe7b4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/pkg/reconciler/contour/config/contour.go b/pkg/reconciler/contour/config/contour.go
@@ -81,7 +81,7 @@ func NewContourFromConfigMap(configMap *corev1.ConfigMap) (*Contour, error) {
 			return nil, err
 		}
 
-		if len(contourCORSPolicy.AllowOrigin) == 0 || len(contourCORSPolicy.AllowMethods) == 0 {
+		if contourCORSPolicy == nil || len(contourCORSPolicy.AllowOrigin) == 0 || len(contourCORSPolicy.AllowMethods) == 0 {
 			return nil, fmt.Errorf("the following fields are required but are missing or empty: %s.allowOrigin and %s.allowMethods", corsPolicy, corsPolicy)
 		}
 

diff --git a/pkg/reconciler/contour/config/contour_test.go b/pkg/reconciler/contour/config/contour_test.go
@@ -174,6 +174,18 @@ maxAge: "10m"
 `,
 			},
 		},
+	}, {
+		name:    "empty configuration",
+		wantErr: true,
+		config: &corev1.ConfigMap{
+			ObjectMeta: metav1.ObjectMeta{
+				Namespace: system.Namespace(),
+				Name:      ContourConfigName,
+			},
+			Data: map[string]string{
+				corsPolicy: "",
+			},
+		},
 	}, {
 		name:    "wrong option",
 		wantErr: true,