Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip-review label on automated yaml/image bumps #347

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ReToCode
Copy link
Member

See discussion in https://cloud-native.slack.com/archives/C04LY4M2G49/p1697606859044749

Changes

Add skip-review label on automated yaml/image bumps to skip reviews on automated bumps of dependant YAML and images, as it makes not much sense to review them manually (these diff are not really reviewable: changed the image)

/assign @dprotaso
/assign @upodroid

@knative-prow knative-prow bot requested review from cardil and upodroid November 28, 2023 11:29
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 28, 2023
Copy link
Contributor

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You also need to make one more change in the prow config

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
Copy link

knative-prow bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3c35840 into knative-extensions:main Nov 28, 2023
2 checks passed
@ReToCode
Copy link
Member Author

You also need to make one more change in the prow config

Im not sure where you mean, can you link to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants