Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source docs improvements #907

Merged

Conversation

gabo1208
Copy link
Contributor

Changes

  • 🐛 Fixed bug where the Source BackoffDelay was being parsed incorrectly
  • 🎁 Added retries configuration samples for Sources and Brokers/Triggers

/kind bug documentation

Fixes #900

Release Note

🐛 Fixed bug where the Source BackoffDelay was being parsed incorrectly

@knative-prow knative-prow bot added kind/bug Categorizes issue or PR as related to a bug. kind/documentation size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #907 (848cd25) into main (6d2e8ae) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
+ Coverage   71.11%   71.14%   +0.03%     
==========================================
  Files          43       43              
  Lines        2970     2970              
==========================================
+ Hits         2112     2113       +1     
+ Misses        779      778       -1     
  Partials       79       79              
Impacted Files Coverage Δ
pkg/dispatcher/dispatcher.go 42.96% <ø> (+0.31%) ⬆️
pkg/rabbit/message.go 71.42% <0.00%> (+2.52%) ⬆️
pkg/adapter/adapter.go 60.97% <100.00%> (-1.38%) ⬇️
pkg/reconciler/source/resources/receive_adapter.go 95.38% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits with the title

samples/quick-setup/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Aug 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2022
@knative-prow knative-prow bot merged commit 3fe24f6 into knative-extensions:main Aug 29, 2022
@gabo1208
Copy link
Contributor Author

/cherry-pick release-1.7

@knative-prow-robot
Copy link

@gabo1208: new pull request created: #909

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. kind/documentation lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitmqSource documentation bugs
3 participants