Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] Override and escape component provided by controller. #840

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #827

Fix metrics component name for user-facing components. Also escape it.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #840 (eebe960) into release-1.5 (eebe960) will not change coverage.
The diff coverage is n/a.

❗ Current head eebe960 differs from pull request most recent head fc8fb04. Consider uploading reports for the commit fc8fb04 to get more accurate results

@@             Coverage Diff              @@
##           release-1.5     #840   +/-   ##
============================================
  Coverage        74.64%   74.64%           
============================================
  Files               38       38           
  Lines             2528     2528           
============================================
  Hits              1887     1887           
  Misses             577      577           
  Partials            64       64           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebe960...fc8fb04. Read the comment docs.

@gab-satchi
Copy link
Contributor

/retest

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@knative-prow
Copy link

knative-prow bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2022
@knative-prow knative-prow bot merged commit 203aa3d into knative-extensions:release-1.5 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants