Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf test organization #721

Merged
merged 8 commits into from
Apr 20, 2022

Conversation

gabo1208
Copy link
Contributor

Changes

  • 🐛 Fixed wrong performance values in sender throughput graph that were really its latency
  • 🧹 Added sender throughput graph
  • 🧹 Bettter organization for tests and docs
  • 🧹 Added source basic arch diagram

/kind enhancement

Release Note

Now the docs are better organized and performance tests graphs are correct

@knative-prow knative-prow bot added kind/enhancement approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 19, 2022
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 19, 2022
@gabo1208 gabo1208 force-pushed the perf-test-organization branch from 77823ba to a9c058e Compare April 19, 2022 01:18
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #721 (880bdbd) into main (81984b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   75.38%   75.38%           
=======================================
  Files          32       32           
  Lines        2397     2397           
=======================================
  Hits         1807     1807           
  Misses        523      523           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81984b2...880bdbd. Read the comment docs.

@gabo1208 gabo1208 requested review from salaboy and ikavgo April 19, 2022 18:58
Copy link

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabo1208 perfect! this is great.. having the contributing md file is perfect.. we should merge before this get stale.. sorry for the delay in reviewing!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, salaboy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit f3f95e3 into knative-extensions:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants