Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifies broker address to match other brokers (InMemory, Kafka) #587

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Modifies broker address to match other brokers (InMemory, Kafka) #587

merged 1 commit into from
Feb 28, 2022

Conversation

gab-satchi
Copy link
Contributor

Changes

  • 🧹 Updates broker address URL to include a path with namespace and name

/kind cleanup

Fixes #585

Release Note

- Broker URLs updated to be `http://<broker-URL>/<namespace>/<broker-name>`

@knative-prow-robot knative-prow-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #587 (7f0cbdc) into main (1ed3e8d) will decrease coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
- Coverage   75.50%   75.06%   -0.44%     
==========================================
  Files          47       47              
  Lines        2870     2884      +14     
==========================================
- Hits         2167     2165       -2     
- Misses        565      581      +16     
  Partials      138      138
Impacted Files Coverage Δ
pkg/reconciler/broker/broker.go 89.44% <100.00%> (+0.05%) ⬆️
pkg/reconciler/trigger/resources/queue.go 42.50% <0.00%> (-31.58%) ⬇️
pkg/apis/duck/v1beta1/rabbit.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed3e8d...7f0cbdc. Read the comment docs.

@xtreme-sameer-vohra
Copy link
Contributor

/retest

@xtreme-sameer-vohra
Copy link
Contributor

/retest

salaboy
salaboy approved these changes Feb 28, 2022
View reviewed changes
Copy link

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests are working this change follows the same URL pattern than other implementations

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2022
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, salaboy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2022
@knative-prow-robot knative-prow-robot merged commit 6d564c5 into knative-extensions:main Feb 28, 2022
gab-satchi added a commit to gab-satchi/eventing-rabbitmq that referenced this pull request Mar 9, 2022
@gab-satchi
Revert "Modifies broker address to match other brokers (InMemory, Kaf…
d756905 
…ka) (knative-extensions#587)"

This reverts commit 6d564c5.
knative-prow-robot pushed a commit that referenced this pull request Mar 9, 2022
@gab-satchi @knative-automation
Conformance test fix attempt (#632)
8428c02 
* upgrade to latest dependencies

bumping knative.dev/reconciler-test 2c3291f...84821d2:
  > 84821d2 Retry on context deadline exceeded errors (# 305)
  > d6d7c14 Update actions (# 291)
  > e2e54d1 Update community files (# 298)
  > 1b5d730 upgrade to latest dependencies (# 296)
bumping golang.org/x/term 6a3ed07...03fcf44:
  > 03fcf44 term: add codereview.cfg
  > f766a8b term: enable TestMakeRawState on darwin/arm64
  > 140adaa term: add portability note re: std{in,out} fds
  > 6886f2d all: upgrade x/sys to latest
  > a79de54 go.mod: upgrade to go 1.17
  > c04ba85 term: unify ioctl{Read,Write}Termios definition for aix, linux, solaris & zos
  > f5beecf term: skip TestMakeRawState on GOOS=ios
  > b80969c term: add aix and zos build tags
  > 72f3dc4 term: use existing unix implementation on solaris
  > de623e6 term: use stdin file descriptor in comment
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping golang.org/x/sys fe61309...4e6760a:
  > 4e6760a unix: add SPEED_UNKNOWN
  > 95c6836 unix: add Kernel Connection Multiplexor ioctl helpers
  > dbe011f unix: add Linux Kernel Connection Multiplexor types and constants
  > 96fed51 unix: add can netlink types and constants
  > f242548 unix/linux: update to Go 1.18rc1
  > 0005352 unix: Getwd: ensure returned path is absolute
  > b146bce unix: remove accept on Linux
  > 3681064 unix: implement getitimer(2) and setitimer(2) on Linux
  > 5739886 unix: implement alarm(2) on Linux on all GOARCH except arm* and riscv.
  > 1c1b9b1 unix/linux: update to glibc 2.35, Go 1.17.6
  > 99c3d69 unix: enable sysctl tests on netbsd
  > da31bd3 unix: lock the thread for TestPrctlRetInt
  > 5a964db windows: add Get{Active,Maximum}ProcesorCount
  > a018aaa unix/linux: update to Linux Kernel 5.16
  > 1d35b9e windows/svc: use NtQuerySystemInformation in IsWindowsService
  > 4abf325 unix: add netlink attribute type and policy type constants
  > 4825e8c unix: add WireGuard generic netlink interface constants on Linux
  > 3b038e5 windows: set pipe explicitly inheritable in test for go 1.16
  > 024a26f unix: regenerate generic netlink controller constants
  > 03aa0b5 windows: allocate attribute list with LocalAlloc, not individual items
  > af8b642 unix: use pipe2 syscall in Pipe on NetBSD
  > 798191b unix, plan9: avoid writing to p when Pipe(p) fails
  > 97ca703 cpu: remove the declaration of function darwinSupportsAVX512
  > 94396e4 windows: add ModuleEntry32 type and Module32{First,Next} wrappers
bumping knative.dev/pkg d481724...2fdd5f2:
  > 2fdd5f2 Update actions (# 2449)
  > 76a28b0 set git user name/email prior to merging upstream (# 2448)
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)
bumping knative.dev/eventing cbf1b08...9590bc3:
  > 9590bc3 adding min and max nodes annotation to rekt tests entrypoint (# 6243)
  > 4252411 Increase rekt test timings and reduce concurrency (# 6221)
  > 6fabdd5 Remove a second trigger of the autoscaler (# 6203)
  > 28a968c upgrade to latest dependencies (# 6230)
  > b349443 fixed links to source.md (# 6223)
  > f40fc74 Zero placements for rebalancing (# 6204)
  > 78aae1e Update community files (# 6220)
  > fdaca85 Update actions (# 6218)
  > 7ab1b0e upgrade to latest dependencies (# 6216)
  > f2045b0 upgrade to latest dependencies (# 6212)
  > 6d5c49a Update community files (# 6146)
  > 2b9baf3 Update actions (# 6174)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping golang.org/x/net 491a49a...27dd868:
  > 27dd868 http2: improve handling of slow-closing net.Conns
  > 3bcbab3 ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > f80d34d ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > cd36cc0 internal/socket: reuse closure in Recv/SendMmsg
  > 2fabfed internal/socket: use unix cmsg functions on zos
  > e204ce3 netutil: in TestLimitListenerSaturation, allow some connections to fail to dial
  > 2ed6ce1 http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester
  > 4395403 go.mod: update imports to current versions
  > 0dd24b2 http2: eliminate arbitrary timeouts in readFrame methods
  > d55c255 ipv4, ipv6, internal/socket: add loong64 support
  > 5cfca57 ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > 8b8fc08 ipv6: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > 5b0dc2d netutil: make LimitListener tests more robust
  > fe4d628 netutil: streamline and simplify LimitListener tests
  > 4ddde0e http2: fix tipo in comment

Signed-off-by: Knative Automation <[email protected]>

* Revert "Modifies broker address to match other brokers (InMemory, Kafka) (#587)"

This reverts commit 6d564c5.

Co-authored-by: Knative Automation <[email protected]>
gabo1208 pushed a commit to gabo1208/eventing-rabbitmq that referenced this pull request Mar 9, 2022
@gab-satchi @knative-automation @gabo1208
Conformance test fix attempt (knative-extensions#632)
0107cf7 
* upgrade to latest dependencies

bumping knative.dev/reconciler-test 2c3291f...84821d2:
  > 84821d2 Retry on context deadline exceeded errors (# 305)
  > d6d7c14 Update actions (# 291)
  > e2e54d1 Update community files (# 298)
  > 1b5d730 upgrade to latest dependencies (# 296)
bumping golang.org/x/term 6a3ed07...03fcf44:
  > 03fcf44 term: add codereview.cfg
  > f766a8b term: enable TestMakeRawState on darwin/arm64
  > 140adaa term: add portability note re: std{in,out} fds
  > 6886f2d all: upgrade x/sys to latest
  > a79de54 go.mod: upgrade to go 1.17
  > c04ba85 term: unify ioctl{Read,Write}Termios definition for aix, linux, solaris & zos
  > f5beecf term: skip TestMakeRawState on GOOS=ios
  > b80969c term: add aix and zos build tags
  > 72f3dc4 term: use existing unix implementation on solaris
  > de623e6 term: use stdin file descriptor in comment
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping golang.org/x/sys fe61309...4e6760a:
  > 4e6760a unix: add SPEED_UNKNOWN
  > 95c6836 unix: add Kernel Connection Multiplexor ioctl helpers
  > dbe011f unix: add Linux Kernel Connection Multiplexor types and constants
  > 96fed51 unix: add can netlink types and constants
  > f242548 unix/linux: update to Go 1.18rc1
  > 0005352 unix: Getwd: ensure returned path is absolute
  > b146bce unix: remove accept on Linux
  > 3681064 unix: implement getitimer(2) and setitimer(2) on Linux
  > 5739886 unix: implement alarm(2) on Linux on all GOARCH except arm* and riscv.
  > 1c1b9b1 unix/linux: update to glibc 2.35, Go 1.17.6
  > 99c3d69 unix: enable sysctl tests on netbsd
  > da31bd3 unix: lock the thread for TestPrctlRetInt
  > 5a964db windows: add Get{Active,Maximum}ProcesorCount
  > a018aaa unix/linux: update to Linux Kernel 5.16
  > 1d35b9e windows/svc: use NtQuerySystemInformation in IsWindowsService
  > 4abf325 unix: add netlink attribute type and policy type constants
  > 4825e8c unix: add WireGuard generic netlink interface constants on Linux
  > 3b038e5 windows: set pipe explicitly inheritable in test for go 1.16
  > 024a26f unix: regenerate generic netlink controller constants
  > 03aa0b5 windows: allocate attribute list with LocalAlloc, not individual items
  > af8b642 unix: use pipe2 syscall in Pipe on NetBSD
  > 798191b unix, plan9: avoid writing to p when Pipe(p) fails
  > 97ca703 cpu: remove the declaration of function darwinSupportsAVX512
  > 94396e4 windows: add ModuleEntry32 type and Module32{First,Next} wrappers
bumping knative.dev/pkg d481724...2fdd5f2:
  > 2fdd5f2 Update actions (# 2449)
  > 76a28b0 set git user name/email prior to merging upstream (# 2448)
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)
bumping knative.dev/eventing cbf1b08...9590bc3:
  > 9590bc3 adding min and max nodes annotation to rekt tests entrypoint (# 6243)
  > 4252411 Increase rekt test timings and reduce concurrency (# 6221)
  > 6fabdd5 Remove a second trigger of the autoscaler (# 6203)
  > 28a968c upgrade to latest dependencies (# 6230)
  > b349443 fixed links to source.md (# 6223)
  > f40fc74 Zero placements for rebalancing (# 6204)
  > 78aae1e Update community files (# 6220)
  > fdaca85 Update actions (# 6218)
  > 7ab1b0e upgrade to latest dependencies (# 6216)
  > f2045b0 upgrade to latest dependencies (# 6212)
  > 6d5c49a Update community files (# 6146)
  > 2b9baf3 Update actions (# 6174)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping golang.org/x/net 491a49a...27dd868:
  > 27dd868 http2: improve handling of slow-closing net.Conns
  > 3bcbab3 ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > f80d34d ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > cd36cc0 internal/socket: reuse closure in Recv/SendMmsg
  > 2fabfed internal/socket: use unix cmsg functions on zos
  > e204ce3 netutil: in TestLimitListenerSaturation, allow some connections to fail to dial
  > 2ed6ce1 http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester
  > 4395403 go.mod: update imports to current versions
  > 0dd24b2 http2: eliminate arbitrary timeouts in readFrame methods
  > d55c255 ipv4, ipv6, internal/socket: add loong64 support
  > 5cfca57 ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > 8b8fc08 ipv6: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > 5b0dc2d netutil: make LimitListener tests more robust
  > fe4d628 netutil: streamline and simplify LimitListener tests
  > 4ddde0e http2: fix tipo in comment

Signed-off-by: Knative Automation <[email protected]>

* Revert "Modifies broker address to match other brokers (InMemory, Kafka) (knative-extensions#587)"

This reverts commit 6d564c5.

Co-authored-by: Knative Automation <[email protected]>
gabo1208 pushed a commit to gabo1208/eventing-rabbitmq that referenced this pull request Mar 9, 2022
@gab-satchi @knative-automation @gabo1208
Conformance test fix attempt (knative-extensions#632)
d015135 
* upgrade to latest dependencies

bumping knative.dev/reconciler-test 2c3291f...84821d2:
  > 84821d2 Retry on context deadline exceeded errors (# 305)
  > d6d7c14 Update actions (# 291)
  > e2e54d1 Update community files (# 298)
  > 1b5d730 upgrade to latest dependencies (# 296)
bumping golang.org/x/term 6a3ed07...03fcf44:
  > 03fcf44 term: add codereview.cfg
  > f766a8b term: enable TestMakeRawState on darwin/arm64
  > 140adaa term: add portability note re: std{in,out} fds
  > 6886f2d all: upgrade x/sys to latest
  > a79de54 go.mod: upgrade to go 1.17
  > c04ba85 term: unify ioctl{Read,Write}Termios definition for aix, linux, solaris & zos
  > f5beecf term: skip TestMakeRawState on GOOS=ios
  > b80969c term: add aix and zos build tags
  > 72f3dc4 term: use existing unix implementation on solaris
  > de623e6 term: use stdin file descriptor in comment
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping golang.org/x/sys fe61309...4e6760a:
  > 4e6760a unix: add SPEED_UNKNOWN
  > 95c6836 unix: add Kernel Connection Multiplexor ioctl helpers
  > dbe011f unix: add Linux Kernel Connection Multiplexor types and constants
  > 96fed51 unix: add can netlink types and constants
  > f242548 unix/linux: update to Go 1.18rc1
  > 0005352 unix: Getwd: ensure returned path is absolute
  > b146bce unix: remove accept on Linux
  > 3681064 unix: implement getitimer(2) and setitimer(2) on Linux
  > 5739886 unix: implement alarm(2) on Linux on all GOARCH except arm* and riscv.
  > 1c1b9b1 unix/linux: update to glibc 2.35, Go 1.17.6
  > 99c3d69 unix: enable sysctl tests on netbsd
  > da31bd3 unix: lock the thread for TestPrctlRetInt
  > 5a964db windows: add Get{Active,Maximum}ProcesorCount
  > a018aaa unix/linux: update to Linux Kernel 5.16
  > 1d35b9e windows/svc: use NtQuerySystemInformation in IsWindowsService
  > 4abf325 unix: add netlink attribute type and policy type constants
  > 4825e8c unix: add WireGuard generic netlink interface constants on Linux
  > 3b038e5 windows: set pipe explicitly inheritable in test for go 1.16
  > 024a26f unix: regenerate generic netlink controller constants
  > 03aa0b5 windows: allocate attribute list with LocalAlloc, not individual items
  > af8b642 unix: use pipe2 syscall in Pipe on NetBSD
  > 798191b unix, plan9: avoid writing to p when Pipe(p) fails
  > 97ca703 cpu: remove the declaration of function darwinSupportsAVX512
  > 94396e4 windows: add ModuleEntry32 type and Module32{First,Next} wrappers
bumping knative.dev/pkg d481724...2fdd5f2:
  > 2fdd5f2 Update actions (# 2449)
  > 76a28b0 set git user name/email prior to merging upstream (# 2448)
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)
bumping knative.dev/eventing cbf1b08...9590bc3:
  > 9590bc3 adding min and max nodes annotation to rekt tests entrypoint (# 6243)
  > 4252411 Increase rekt test timings and reduce concurrency (# 6221)
  > 6fabdd5 Remove a second trigger of the autoscaler (# 6203)
  > 28a968c upgrade to latest dependencies (# 6230)
  > b349443 fixed links to source.md (# 6223)
  > f40fc74 Zero placements for rebalancing (# 6204)
  > 78aae1e Update community files (# 6220)
  > fdaca85 Update actions (# 6218)
  > 7ab1b0e upgrade to latest dependencies (# 6216)
  > f2045b0 upgrade to latest dependencies (# 6212)
  > 6d5c49a Update community files (# 6146)
  > 2b9baf3 Update actions (# 6174)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping golang.org/x/net 491a49a...27dd868:
  > 27dd868 http2: improve handling of slow-closing net.Conns
  > 3bcbab3 ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > f80d34d ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > cd36cc0 internal/socket: reuse closure in Recv/SendMmsg
  > 2fabfed internal/socket: use unix cmsg functions on zos
  > e204ce3 netutil: in TestLimitListenerSaturation, allow some connections to fail to dial
  > 2ed6ce1 http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester
  > 4395403 go.mod: update imports to current versions
  > 0dd24b2 http2: eliminate arbitrary timeouts in readFrame methods
  > d55c255 ipv4, ipv6, internal/socket: add loong64 support
  > 5cfca57 ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > 8b8fc08 ipv6: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > 5b0dc2d netutil: make LimitListener tests more robust
  > fe4d628 netutil: streamline and simplify LimitListener tests
  > 4ddde0e http2: fix tipo in comment

Signed-off-by: Knative Automation <[email protected]>

* Revert "Modifies broker address to match other brokers (InMemory, Kafka) (knative-extensions#587)"

This reverts commit 6d564c5.

Co-authored-by: Knative Automation <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request Mar 10, 2022
@gabo1208 @knative-automation @gab-satchi
Automation update deps (#634)
7202816 
* upgrade to latest dependencies

bumping knative.dev/reconciler-test 2c3291f...84821d2:
  > 84821d2 Retry on context deadline exceeded errors (# 305)
  > d6d7c14 Update actions (# 291)
  > e2e54d1 Update community files (# 298)
  > 1b5d730 upgrade to latest dependencies (# 296)
bumping golang.org/x/term 6a3ed07...03fcf44:
  > 03fcf44 term: add codereview.cfg
  > f766a8b term: enable TestMakeRawState on darwin/arm64
  > 140adaa term: add portability note re: std{in,out} fds
  > 6886f2d all: upgrade x/sys to latest
  > a79de54 go.mod: upgrade to go 1.17
  > c04ba85 term: unify ioctl{Read,Write}Termios definition for aix, linux, solaris & zos
  > f5beecf term: skip TestMakeRawState on GOOS=ios
  > b80969c term: add aix and zos build tags
  > 72f3dc4 term: use existing unix implementation on solaris
  > de623e6 term: use stdin file descriptor in comment
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping golang.org/x/sys fe61309...4e6760a:
  > 4e6760a unix: add SPEED_UNKNOWN
  > 95c6836 unix: add Kernel Connection Multiplexor ioctl helpers
  > dbe011f unix: add Linux Kernel Connection Multiplexor types and constants
  > 96fed51 unix: add can netlink types and constants
  > f242548 unix/linux: update to Go 1.18rc1
  > 0005352 unix: Getwd: ensure returned path is absolute
  > b146bce unix: remove accept on Linux
  > 3681064 unix: implement getitimer(2) and setitimer(2) on Linux
  > 5739886 unix: implement alarm(2) on Linux on all GOARCH except arm* and riscv.
  > 1c1b9b1 unix/linux: update to glibc 2.35, Go 1.17.6
  > 99c3d69 unix: enable sysctl tests on netbsd
  > da31bd3 unix: lock the thread for TestPrctlRetInt
  > 5a964db windows: add Get{Active,Maximum}ProcesorCount
  > a018aaa unix/linux: update to Linux Kernel 5.16
  > 1d35b9e windows/svc: use NtQuerySystemInformation in IsWindowsService
  > 4abf325 unix: add netlink attribute type and policy type constants
  > 4825e8c unix: add WireGuard generic netlink interface constants on Linux
  > 3b038e5 windows: set pipe explicitly inheritable in test for go 1.16
  > 024a26f unix: regenerate generic netlink controller constants
  > 03aa0b5 windows: allocate attribute list with LocalAlloc, not individual items
  > af8b642 unix: use pipe2 syscall in Pipe on NetBSD
  > 798191b unix, plan9: avoid writing to p when Pipe(p) fails
  > 97ca703 cpu: remove the declaration of function darwinSupportsAVX512
  > 94396e4 windows: add ModuleEntry32 type and Module32{First,Next} wrappers
bumping knative.dev/pkg d481724...2fdd5f2:
  > 2fdd5f2 Update actions (# 2449)
  > 76a28b0 set git user name/email prior to merging upstream (# 2448)
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)
bumping knative.dev/eventing cbf1b08...9590bc3:
  > 9590bc3 adding min and max nodes annotation to rekt tests entrypoint (# 6243)
  > 4252411 Increase rekt test timings and reduce concurrency (# 6221)
  > 6fabdd5 Remove a second trigger of the autoscaler (# 6203)
  > 28a968c upgrade to latest dependencies (# 6230)
  > b349443 fixed links to source.md (# 6223)
  > f40fc74 Zero placements for rebalancing (# 6204)
  > 78aae1e Update community files (# 6220)
  > fdaca85 Update actions (# 6218)
  > 7ab1b0e upgrade to latest dependencies (# 6216)
  > f2045b0 upgrade to latest dependencies (# 6212)
  > 6d5c49a Update community files (# 6146)
  > 2b9baf3 Update actions (# 6174)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping golang.org/x/net 491a49a...27dd868:
  > 27dd868 http2: improve handling of slow-closing net.Conns
  > 3bcbab3 ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > f80d34d ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > cd36cc0 internal/socket: reuse closure in Recv/SendMmsg
  > 2fabfed internal/socket: use unix cmsg functions on zos
  > e204ce3 netutil: in TestLimitListenerSaturation, allow some connections to fail to dial
  > 2ed6ce1 http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester
  > 4395403 go.mod: update imports to current versions
  > 0dd24b2 http2: eliminate arbitrary timeouts in readFrame methods
  > d55c255 ipv4, ipv6, internal/socket: add loong64 support
  > 5cfca57 ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > 8b8fc08 ipv6: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > 5b0dc2d netutil: make LimitListener tests more robust
  > fe4d628 netutil: streamline and simplify LimitListener tests
  > 4ddde0e http2: fix tipo in comment

Signed-off-by: Knative Automation <[email protected]>

* Conformance test fix attempt (#632)

* upgrade to latest dependencies

bumping knative.dev/reconciler-test 2c3291f...84821d2:
  > 84821d2 Retry on context deadline exceeded errors (# 305)
  > d6d7c14 Update actions (# 291)
  > e2e54d1 Update community files (# 298)
  > 1b5d730 upgrade to latest dependencies (# 296)
bumping golang.org/x/term 6a3ed07...03fcf44:
  > 03fcf44 term: add codereview.cfg
  > f766a8b term: enable TestMakeRawState on darwin/arm64
  > 140adaa term: add portability note re: std{in,out} fds
  > 6886f2d all: upgrade x/sys to latest
  > a79de54 go.mod: upgrade to go 1.17
  > c04ba85 term: unify ioctl{Read,Write}Termios definition for aix, linux, solaris & zos
  > f5beecf term: skip TestMakeRawState on GOOS=ios
  > b80969c term: add aix and zos build tags
  > 72f3dc4 term: use existing unix implementation on solaris
  > de623e6 term: use stdin file descriptor in comment
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping golang.org/x/sys fe61309...4e6760a:
  > 4e6760a unix: add SPEED_UNKNOWN
  > 95c6836 unix: add Kernel Connection Multiplexor ioctl helpers
  > dbe011f unix: add Linux Kernel Connection Multiplexor types and constants
  > 96fed51 unix: add can netlink types and constants
  > f242548 unix/linux: update to Go 1.18rc1
  > 0005352 unix: Getwd: ensure returned path is absolute
  > b146bce unix: remove accept on Linux
  > 3681064 unix: implement getitimer(2) and setitimer(2) on Linux
  > 5739886 unix: implement alarm(2) on Linux on all GOARCH except arm* and riscv.
  > 1c1b9b1 unix/linux: update to glibc 2.35, Go 1.17.6
  > 99c3d69 unix: enable sysctl tests on netbsd
  > da31bd3 unix: lock the thread for TestPrctlRetInt
  > 5a964db windows: add Get{Active,Maximum}ProcesorCount
  > a018aaa unix/linux: update to Linux Kernel 5.16
  > 1d35b9e windows/svc: use NtQuerySystemInformation in IsWindowsService
  > 4abf325 unix: add netlink attribute type and policy type constants
  > 4825e8c unix: add WireGuard generic netlink interface constants on Linux
  > 3b038e5 windows: set pipe explicitly inheritable in test for go 1.16
  > 024a26f unix: regenerate generic netlink controller constants
  > 03aa0b5 windows: allocate attribute list with LocalAlloc, not individual items
  > af8b642 unix: use pipe2 syscall in Pipe on NetBSD
  > 798191b unix, plan9: avoid writing to p when Pipe(p) fails
  > 97ca703 cpu: remove the declaration of function darwinSupportsAVX512
  > 94396e4 windows: add ModuleEntry32 type and Module32{First,Next} wrappers
bumping knative.dev/pkg d481724...2fdd5f2:
  > 2fdd5f2 Update actions (# 2449)
  > 76a28b0 set git user name/email prior to merging upstream (# 2448)
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)
bumping knative.dev/eventing cbf1b08...9590bc3:
  > 9590bc3 adding min and max nodes annotation to rekt tests entrypoint (# 6243)
  > 4252411 Increase rekt test timings and reduce concurrency (# 6221)
  > 6fabdd5 Remove a second trigger of the autoscaler (# 6203)
  > 28a968c upgrade to latest dependencies (# 6230)
  > b349443 fixed links to source.md (# 6223)
  > f40fc74 Zero placements for rebalancing (# 6204)
  > 78aae1e Update community files (# 6220)
  > fdaca85 Update actions (# 6218)
  > 7ab1b0e upgrade to latest dependencies (# 6216)
  > f2045b0 upgrade to latest dependencies (# 6212)
  > 6d5c49a Update community files (# 6146)
  > 2b9baf3 Update actions (# 6174)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping golang.org/x/net 491a49a...27dd868:
  > 27dd868 http2: improve handling of slow-closing net.Conns
  > 3bcbab3 ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > f80d34d ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > cd36cc0 internal/socket: reuse closure in Recv/SendMmsg
  > 2fabfed internal/socket: use unix cmsg functions on zos
  > e204ce3 netutil: in TestLimitListenerSaturation, allow some connections to fail to dial
  > 2ed6ce1 http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester
  > 4395403 go.mod: update imports to current versions
  > 0dd24b2 http2: eliminate arbitrary timeouts in readFrame methods
  > d55c255 ipv4, ipv6, internal/socket: add loong64 support
  > 5cfca57 ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > 8b8fc08 ipv6: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > 5b0dc2d netutil: make LimitListener tests more robust
  > fe4d628 netutil: streamline and simplify LimitListener tests
  > 4ddde0e http2: fix tipo in comment

Signed-off-by: Knative Automation <[email protected]>

* Revert "Modifies broker address to match other brokers (InMemory, Kafka) (#587)"

This reverts commit 6d564c5.

Co-authored-by: Knative Automation <[email protected]>

Co-authored-by: Knative Automation <[email protected]>
Co-authored-by: Gab Satchi <[email protected]>
knative-prow-robot pushed a commit that referenced this pull request Mar 10, 2022
@gabo1208 @knative-automation @gab-satchi
Nightly job (#635)
4f5a130 
* Update eventing nightly

Signed-off-by: Knative Automation <[email protected]>

* Update actions (#617)

Signed-off-by: Knative Automation <[email protected]>

* Conformance test fix attempt (#632)

* upgrade to latest dependencies

bumping knative.dev/reconciler-test 2c3291f...84821d2:
  > 84821d2 Retry on context deadline exceeded errors (# 305)
  > d6d7c14 Update actions (# 291)
  > e2e54d1 Update community files (# 298)
  > 1b5d730 upgrade to latest dependencies (# 296)
bumping golang.org/x/term 6a3ed07...03fcf44:
  > 03fcf44 term: add codereview.cfg
  > f766a8b term: enable TestMakeRawState on darwin/arm64
  > 140adaa term: add portability note re: std{in,out} fds
  > 6886f2d all: upgrade x/sys to latest
  > a79de54 go.mod: upgrade to go 1.17
  > c04ba85 term: unify ioctl{Read,Write}Termios definition for aix, linux, solaris & zos
  > f5beecf term: skip TestMakeRawState on GOOS=ios
  > b80969c term: add aix and zos build tags
  > 72f3dc4 term: use existing unix implementation on solaris
  > de623e6 term: use stdin file descriptor in comment
bumping knative.dev/hack a8ef7b6...e178598:
  > e178598 Update community files (# 157)
  > cf8cbc0 Fix the regex used for matching GitHub Actions files (# 156)
bumping golang.org/x/sys fe61309...4e6760a:
  > 4e6760a unix: add SPEED_UNKNOWN
  > 95c6836 unix: add Kernel Connection Multiplexor ioctl helpers
  > dbe011f unix: add Linux Kernel Connection Multiplexor types and constants
  > 96fed51 unix: add can netlink types and constants
  > f242548 unix/linux: update to Go 1.18rc1
  > 0005352 unix: Getwd: ensure returned path is absolute
  > b146bce unix: remove accept on Linux
  > 3681064 unix: implement getitimer(2) and setitimer(2) on Linux
  > 5739886 unix: implement alarm(2) on Linux on all GOARCH except arm* and riscv.
  > 1c1b9b1 unix/linux: update to glibc 2.35, Go 1.17.6
  > 99c3d69 unix: enable sysctl tests on netbsd
  > da31bd3 unix: lock the thread for TestPrctlRetInt
  > 5a964db windows: add Get{Active,Maximum}ProcesorCount
  > a018aaa unix/linux: update to Linux Kernel 5.16
  > 1d35b9e windows/svc: use NtQuerySystemInformation in IsWindowsService
  > 4abf325 unix: add netlink attribute type and policy type constants
  > 4825e8c unix: add WireGuard generic netlink interface constants on Linux
  > 3b038e5 windows: set pipe explicitly inheritable in test for go 1.16
  > 024a26f unix: regenerate generic netlink controller constants
  > 03aa0b5 windows: allocate attribute list with LocalAlloc, not individual items
  > af8b642 unix: use pipe2 syscall in Pipe on NetBSD
  > 798191b unix, plan9: avoid writing to p when Pipe(p) fails
  > 97ca703 cpu: remove the declaration of function darwinSupportsAVX512
  > 94396e4 windows: add ModuleEntry32 type and Module32{First,Next} wrappers
bumping knative.dev/pkg d481724...2fdd5f2:
  > 2fdd5f2 Update actions (# 2449)
  > 76a28b0 set git user name/email prior to merging upstream (# 2448)
  > fe26417 Allow overriding lease name for a reconciler (# 2435)
  > 9b5c411 allow overriding the default grace period of 45 seconds (# 2423)
  > 4c2331f Bump golang.org/x/crypto (# 2444)
  > 708dc1c Update community files (# 2443)
  > 062ca30 upgrade to latest dependencies (# 2433)
  > 4fcbc1b Update actions (# 2434)
  > 80c511a Wait for reconciler/controllers to return prior to exiting the process (# 2437)
bumping knative.dev/eventing cbf1b08...9590bc3:
  > 9590bc3 adding min and max nodes annotation to rekt tests entrypoint (# 6243)
  > 4252411 Increase rekt test timings and reduce concurrency (# 6221)
  > 6fabdd5 Remove a second trigger of the autoscaler (# 6203)
  > 28a968c upgrade to latest dependencies (# 6230)
  > b349443 fixed links to source.md (# 6223)
  > f40fc74 Zero placements for rebalancing (# 6204)
  > 78aae1e Update community files (# 6220)
  > fdaca85 Update actions (# 6218)
  > 7ab1b0e upgrade to latest dependencies (# 6216)
  > f2045b0 upgrade to latest dependencies (# 6212)
  > 6d5c49a Update community files (# 6146)
  > 2b9baf3 Update actions (# 6174)
bumping golang.org/x/crypto 84f3576...8634188:
  > 8634188 acme/autocert: skip renewal tests broken on windows/arm64
  > 1e6e349 crypto/ssh: don't send the last auth failure message if disconnecting
  > f4118a5 acme/autocert: fix races in renewal tests
  > db63837 ssh: accept WSAECONNABORTED in TestClientAuthMaxAuthTriesPublicKey
  > dad3315 acme/autocert: include email in example
  > 2f5cac0 acme, sha3, ssh: fix the typos
  > 65fa2f7 acme: remove support for pre-RFC 8555 ACME spec
  > bba287d ocsp: fix typo
  > 20e1d8d ed25519: drop Go 1.12 compatibility
  > 30dcbda acme: expose Client KID field
  > 198e437 acme/autocert: replace all ACME server stubs with acmetest
  > aa10faf acme/autocert: renew Let's Encrypt certificates likely to get revoked
  > e04a857 ssh/agent: fix TestMalformedRequests
  > 5e0467b acme: in TestFetchCertCancel, do not reply before the cancellation propagates
  > e495a2d cryptobyte: fix parsing of large ASN.1 OIDs
  > 4570a08 internal/wycheproof: skip on builders with flaky network connections
  > 5770296 ssh: don't assume packet plaintext size
  > ae814b3 all: upgrade x/net to latest
  > b4de73f ssh: support RSA SHA-2 (RFC8332) signatures
  > ceb1ce7 ocsp: rewrite tests that rely on SHA1-RSA
  > 089bfa5 acme: implement Client.ListCertAlternates
bumping golang.org/x/net 491a49a...27dd868:
  > 27dd868 http2: improve handling of slow-closing net.Conns
  > 3bcbab3 ipv4: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > f80d34d ipv4: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > cd36cc0 internal/socket: reuse closure in Recv/SendMmsg
  > 2fabfed internal/socket: use unix cmsg functions on zos
  > e204ce3 netutil: in TestLimitListenerSaturation, allow some connections to fail to dial
  > 2ed6ce1 http2: in TestContentEncodingNoSniffing, do not allow the Transport to outlive the serverTester
  > 4395403 go.mod: update imports to current versions
  > 0dd24b2 http2: eliminate arbitrary timeouts in readFrame methods
  > d55c255 ipv4, ipv6, internal/socket: add loong64 support
  > 5cfca57 ipv6: retry ENOBUFS errors in TestPacketConnConcurrentReadWriteUnicast
  > 8b8fc08 ipv6: shut down the PacketConn on failure in TestPacketConnConcurrentReadWriteUnicast
  > 5b0dc2d netutil: make LimitListener tests more robust
  > fe4d628 netutil: streamline and simplify LimitListener tests
  > 4ddde0e http2: fix tipo in comment

Signed-off-by: Knative Automation <[email protected]>

* Revert "Modifies broker address to match other brokers (InMemory, Kafka) (#587)"

This reverts commit 6d564c5.

Co-authored-by: Knative Automation <[email protected]>

Co-authored-by: Knative Automation <[email protected]>
Co-authored-by: Gab Satchi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salaboy salaboy Awaiting requested review from salaboy

@ikavgo ikavgo Awaiting requested review from ikavgo

Assignees

@salaboy salaboy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Following same URL approach than InMemory Broker and Kafka Broker
4 participants
@gab-satchi @xtreme-sameer-vohra @knative-prow-robot @salaboy