Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Metrics for RabbitMQ Eventing Ingress #582

Merged
merged 3 commits into from
May 10, 2022
Merged

Implement Metrics for RabbitMQ Eventing Ingress #582

merged 3 commits into from
May 10, 2022

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Jan 22, 2022 •
edited
Loading

Changes

  • 🎁 Implement Metrics for RabbitMQ Eventing Ingress
  • 🎁 Go runtime MemStat metrics for Dispatcher

/kind enhancement
See #415

Release Note

- Metrics for RabbitMQ Eventing Ingress
- Go runtime MemStat metrics for Dispatcher

Docs

@knative-prow-robot
Copy link

@ikvmw: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ikvmw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 22, 2022
@ikavgo ikavgo marked this pull request as draft January 22, 2022 20:37
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2022
@codecov
Copy link

codecov bot commented Jan 22, 2022 •
edited
Loading

Codecov Report

Merging #582 (f85c1bf) into main (05861dd) will increase coverage by 0.39%.
The diff coverage is 88.31%.

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   74.67%   75.07%   +0.39%     
==========================================
  Files          35       36       +1     
  Lines        2492     2568      +76     
==========================================
+ Hits         1861     1928      +67     
- Misses        562      568       +6     
- Partials       69       72       +3
Impacted Files Coverage Δ
pkg/broker/ingress/stats_exporter.go 85.48% <85.48%> (ø)
pkg/reconciler/broker/resources/ingress.go 97.11% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05861dd...f85c1bf. Read the comment docs.

@ikavgo
Copy link
Contributor Author

ikavgo commented Jan 22, 2022

waiting for #583

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2022
@ikavgo ikavgo changed the title Metrics 415 Implement Metrics for RabbitMQ Eventing Ingress Apr 19, 2022
@ikavgo ikavgo marked this pull request as ready for review April 19, 2022 11:29
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 19, 2022
gab-satchi
gab-satchi reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@gab-satchi gab-satchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome to see metrics being brought in 👍

Can we link to the knative.dev docs somewhere in our own docs so users can learn more?

cmd/ingress/main.go
}

ack := dc.Wait()
dispatchTime := time.Since(start)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just for readability, move this calculation after the error handling on L225

pkg/broker/ingress/stats_exporter.go Show resolved Hide resolved
pkg/broker/ingress/stats_exporter.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2022
salaboy
salaboy approved these changes Apr 22, 2022
View reviewed changes
Copy link

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a great conversation with @ikvmw so I got loads of context of where we are with this PR.
I think we need to merge this PR as is and plan to refactor the shared bits with the in-memory broker, as well as discuss the dispatcher + cloudevents SDK metrics implementation.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ikvmw, salaboy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@salaboy
Copy link

salaboy commented Apr 23, 2022

@ikvmw I think this PR only needs rebase for merging it.. @gabo1208 or @gab-satchi did you already got all your comments answered?

@gab-satchi
Copy link
Contributor

@salaboy no I didn't. combining the 2 methods is just refactoring but I do think it'll be valuable to measure unsuccessful calls as well as successful ones.

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@ikavgo
Copy link
Contributor Author

ikavgo commented Apr 27, 2022

/lgtm

@knative-prow
Copy link

knative-prow bot commented Apr 27, 2022

@ikvmw: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@salaboy
Copy link

salaboy commented Apr 29, 2022

@ikvmw are we waiting on something to merge this one?

@gab-satchi
Copy link
Contributor

/retest

@gab-satchi
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2022
@knative-prow knative-prow bot merged commit 493d4c8 into knative-extensions:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gab-satchi gab-satchi gab-satchi left review comments

@salaboy salaboy salaboy approved these changes

@gabo1208 gabo1208 Awaiting requested review from gabo1208

Assignees

@salaboy salaboy

@gab-satchi gab-satchi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ikavgo @knative-prow-robot @salaboy @gab-satchi