Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.11] Delivery failure #1188

Conversation

knative-prow-robot
Copy link

This is an automated cherry-pick of #1163

Added error information to failed messages

thomasjohansen and others added 29 commits July 31, 2023 18:56
…ed in the trigger, if its not defined in the trigger then in the broker, and if neither is defined then they are not rerouted
@knative-prow-robot knative-prow-robot force-pushed the cherry-pick-1163-to-release-1.11 branch from 148ed36 to 4fa9e5b Compare July 31, 2023 18:56
@knative-prow knative-prow bot requested review from gabo1208 and zroubalik July 31, 2023 18:56
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 31, 2023
@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1188 (4fa9e5b) into release-1.11 (cc5ce6a) will increase coverage by 0.03%.
The diff coverage is 47.65%.

@@               Coverage Diff                @@
##           release-1.11    #1188      +/-   ##
================================================
+ Coverage         74.56%   74.59%   +0.03%     
================================================
  Files                44       44              
  Lines              3298     3417     +119     
================================================
+ Hits               2459     2549      +90     
- Misses              754      767      +13     
- Partials             85      101      +16     
Files Changed Coverage Δ
pkg/rabbit/rabbit_mocks.go 78.37% <ø> (+11.71%) ⬆️
pkg/dispatcher/dispatcher.go 50.82% <36.88%> (+8.75%) ⬆️
pkg/reconciler/trigger/trigger.go 63.19% <80.00%> (+0.18%) ⬆️
pkg/reconciler/broker/broker.go 86.12% <100.00%> (+0.04%) ⬆️
pkg/reconciler/broker/resources/dispatcher.go 94.15% <100.00%> (+0.24%) ⬆️
pkg/reconciler/trigger/resources/dispatcher.go 95.02% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@krsna-m
Copy link

krsna-m commented Jul 31, 2023

/override codecov
/lgtm

@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

@kvmware: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • codecov

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • codecov/patch
  • style / suggester / github_actions
  • style / suggester / shell
  • style / suggester / yaml
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override codecov
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krsna-m
Copy link

krsna-m commented Jul 31, 2023

/override "codecov/patch"

@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

@kvmware: Overrode contexts on behalf of kvmware: codecov/patch

In response to this:

/override "codecov/patch"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 7031a4e into knative-extensions:release-1.11 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants