-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.11] Delivery failure #1188
[release-1.11] Delivery failure #1188
Conversation
…ed in the trigger, if its not defined in the trigger then in the broker, and if neither is defined then they are not rerouted
…se its always going to be nil
… stops when a context cancel gets there
148ed36
to
4fa9e5b
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.11 #1188 +/- ##
================================================
+ Coverage 74.56% 74.59% +0.03%
================================================
Files 44 44
Lines 3298 3417 +119
================================================
+ Hits 2459 2549 +90
- Misses 754 767 +13
- Partials 85 101 +16
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabo1208, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override codecov |
@kvmware: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "codecov/patch" |
@kvmware: Overrode contexts on behalf of kvmware: codecov/patch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #1163