Wrong place to set headers

knative-extensions · Jul 10, 2023 · 30fdc1b · 30fdc1b
1 parent 69ef0b3
commit 30fdc1b
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/dispatcher/dispatcher.go b/pkg/dispatcher/dispatcher.go
@@ -192,14 +192,12 @@ func (d *Dispatcher) dispatch(ctx context.Context, msg amqp.Delivery, ceClient c
 		args := &dispatcher.ReportArgs{EventType: event.Type()}
 		if err = d.Reporter.ReportEventCount(args, statusCode); err != nil {
 			logging.FromContext(ctx).Errorf("Something happened: %v", err)
-
-			msg.Headers["knativeerrordest"] = d.SubscriberURL
-			msg.Headers["knativeerrorcode"] = statusCode
 		}
 	}
 
 	if !isSuccess {
 		logging.FromContext(ctx).Warnf("Failed to deliver to %q", d.SubscriberURL)
+		msg.Headers["knativeerrordest"] = d.SubscriberURL
 		if err = msg.Nack(false, true); err != nil {
 			logging.FromContext(ctx).Warn("failed to NACK event: ", err)
 		}