This repository has been archived by the owner on Jun 14, 2019. It is now read-only.
Cancel pending timeouts so that protractor can continue #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| next.displayName = "#{CONSTANTS.MODULE}/#{CONSTANTS.COMPONENT}: util.send (ensureOpenAuthConnection callback)" | ||
| dispatched = ensureOpenAuthConnection next | ||
| if deferred and !dispatched then deferred.reject() | ||
| if deferred and !dispatched |
There was a problem hiding this comment.
Line ends with trailing whitespace
|
Thank you, I will take a look into this in the next days. Anyway, if you want you contribution being accepted, you have to fork canary, apply the fixes onto that fork any make a PR against my canary. = |
|
Hi, sorry I should have read the guidelines but I I was under the clock last week. I have submitted a new request to canary and I'm closing this one. Many thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using protractor for e2e testing it waits for all pending timeouts to complete and only then will it move on to the next test. For this reason it is important to cancel any timeouts which have been set when they are no longer needed. Currently my tests wait for 10 seconds even though they have received the correct response from the event bus.
This change cancels the send timeout when resolving/rejecting the promise returned and allows protractor to continue once the reply has been received.
An alternative solution would be to use the $interval service instead as I believe that protractor does not wait for these. (angular/protractor#169)