markdown syntax highlighter #2068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine @Bowrna. The JS lint test is failing though. vscode (or any other editor with a VueJS plugin) should ideally have auto-formatted it. |
Bowrna
force-pushed
the
md_editor_highlight
branch
from
3511b16 to
452e1b2
Compare
|
Tested this locally. One minor issue. The editor box styling is a bit broken. It's missing borders and it's height is off. Should be the same as other editors.
|
|
Ah I missed noticing it. Let me fix it. |
Bowrna
force-pushed
the
md_editor_highlight
branch
from
452e1b2 to
a27829a
Compare
|
@knadh updated the styling sheet for markdown-editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #2058
Added fix to support markdown syntax highlighter. As code-flask doesn't support markdown by default, I had to import prism-markdown. Added styles in shadow DOM as style from prismjs doesn't percolate/get injected into shadow DOM.
Let me know if anything has to be modified/ fixed in this PR.