passed the subscription_status param #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bowrna
force-pushed
the
pass_subscription_status_to_filter
branch
from
4830062 to
58bfe11
Compare
knadh
reviewed
Sep 12, 2024
Bowrna
force-pushed
the
pass_subscription_status_to_filter
branch
from
58bfe11 to
0aa95b4
Compare
|
Let me know if I had to add anything more to this PR. Thanks! |
|
Thanks for the PR @Bowrna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1841
related_to: #1985
This issue existed as the subscription_status filter was not passed to the backend. Added a fix by including a new param to send the status, and altered the numbering in parameterized query.
The query affected is a base query template. So all the queries using this base query were in turn affected.