Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users subscribing to double opt-in list are given no indication that they will be receiving a confirmation e-mail #264

Closed
gryphonmyers opened this issue Feb 13, 2021 · 1 comment
Closed

Users subscribing to double opt-in list are given no indication that they will be receiving a confirmation e-mail #264

gryphonmyers opened this issue Feb 13, 2021 · 1 comment
Labels
minor-enhancement Minor enhancement to an existing feature or behaviour

Comments

@gryphonmyers
Copy link

Reproduction Steps:

  1. Create a new public, double opt-in list
  2. Create a subscription form for the list (copying and pasting the content from the 'forms' view for this list)
  3. Use the form to perform a test signup with any e-mail address
  4. Observe that you are taken to a view displaying a "Done. Subscribed successfully" message.

Expected Results:
If a mailing list is public and set to double opt-in, upon submission of an email address, the user should be taken to a view explaining that they will need to confirm their e-mail address. A "Done. Subscribed successfully" message does not adequately explain that their information has been accepted in a tentative state and that further action from them will be required in order to receive further e-mails.
@knadh knadh added the minor-enhancement Minor enhancement to an existing feature or behaviour label Feb 13, 2021
knadh added a commit that referenced this issue Feb 13, 2021
@knadh
Fix the optin-in, form re-subscribe behaviour.
2f6bd05 
If a user is already subscribed to an optin list but hasn't
confirmed, subscribing using the same e-mail id from the public
form now re-sends the optin e-mail while also showing an
appropriate message on the frontend rather than just saying
"subscribed successfully".

#266
#264
@knadh
Copy link
Owner

knadh commented Feb 13, 2021

2f6bd05 fixes this.

@knadh knadh closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
minor-enhancement Minor enhancement to an existing feature or behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@knadh @gryphonmyers