Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken easy docker install on macOS #1740

Closed
root-io opened this issue Feb 19, 2024 · 0 comments · Fixed by #1742
Closed

Broken easy docker install on macOS #1740

root-io opened this issue Feb 19, 2024 · 0 comments · Fixed by #1742
Assignees
@mr-karan
Labels
bug Something isn't working

Comments

@root-io
Copy link

root-io commented Feb 19, 2024 •
edited
Loading

Version:

  • listmonk: 3.0.0
  • OS: macOS

Description of the bug and steps to reproduce:
Running the Easy Docker install creates broken config files, I had to install it manually because I ended up with a config.toml'' and a docker-compose.yml'' file (please note the double ' char).

I think there is an issue with SED_INPLACE

Screenshots:
screenshot
@root-io root-io added the bug Something isn't working label Feb 19, 2024
@root-io root-io changed the title . Broken easy docker install on macOS Feb 19, 2024
mr-karan added a commit that referenced this issue Feb 20, 2024
@mr-karan
feat: fix easy install docker script for macOS
664e026 
Closes #1740
@mr-karan mr-karan self-assigned this Feb 20, 2024
@mr-karan mr-karan mentioned this issue Feb 20, 2024
Merged
knadh pushed a commit that referenced this issue Feb 21, 2024
@mr-karan
fix: easy install docker script for macOS (#1742)
00a44c0 
* feat: fix easy install docker script for macOS

Closes #1740

* fix: use bash shebang for wider compatibility

* fix: quote the command subst to prevent word splitting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mr-karan mr-karan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: easy install docker script for macOS knadh/listmonk
2 participants
@mr-karan @root-io