Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of S3-compatible storage buckets (e.g. Minio, Wasabi, etc.) #139

Closed
eddiewang opened this issue Jun 22, 2020 · 12 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@eddiewang
Copy link

Are there any plans to extend the S3 storage method to allow for a custom S3 endpoint url?

This would allow third-party S3-compatible storage systems to work in tadem with listmonk. This is especially ideal if for self-hosted environments.

@eddiewang eddiewang changed the title Allow use to S3-compatible storage buckets (e.g. Minio, Wasabi, etc.) Allow use of S3-compatible storage buckets (e.g. Minio, Wasabi, etc.) Jun 22, 2020
@knadh
Copy link
Owner

knadh commented Jun 23, 2020

@mr-karan?

@knadh knadh added the enhancement New feature or request label Jun 23, 2020
@mr-karan
Copy link
Collaborator

Currently there are different "providers" for uploading media. These satisfy media.Store interface. Any new provider should do the same. I took a look at Minio SDK and the upload/get functions look similar to S3 provider.

I think we could add Minio to start with. Will add this to my TODO 👍

@eddiewang
Copy link
Author

awesome! glad to see it being prioritized. let me know if you need any assistance. from quickly gandering at the code it would be as simple as allowing the endpoint for the amazon s3 url to be custom set as an environment variable. don't think you would need to use the Minio SDK, since it should be compatible with all s3 clients.

@mr-karan
Copy link
Collaborator

Ah that makes it easier. Will try it out with Minio playground.

@mr-karan mr-karan self-assigned this Jun 28, 2020
@eddiewang
Copy link
Author

hi @mr-karan were you able to get this working with the playground? if you need a dev instance, happy to provide u with one.

joicemjoseph added a commit to joicemjoseph/listmonk that referenced this issue Jul 12, 2020
@mr-karan
Copy link
Collaborator

@eddiewang I was able to upload it by simply changing the endpoint. The Get handler would require some changes as we had made some changes specific to AWS S3. I'm exploring that further on how to provision for both of them semantically in one interface.

@eddiewang
Copy link
Author

eddiewang commented Jul 12, 2020

@mr-karan cool! Was the policy on the bucket set correctly? Assuming we need a public bucket using ‘mc policy set download /’ should do the trick.

joicemjoseph added a commit to joicemjoseph/listmonk that referenced this issue Aug 21, 2020
@knadh knadh closed this as completed Nov 21, 2020
@ifokeev
Copy link

ifokeev commented Feb 16, 2021

Hi! What is about this feature? There are no option in settings to change the host

@knadh
Copy link
Owner

knadh commented Feb 17, 2021

Ah, this isn't available on the settings UI in the current version. Will make it pluggable in the next release.

@joicemjoseph
Copy link
Contributor

#231 is an attempt to add webdav.

@c-nv-s
Copy link

c-nv-s commented Jul 7, 2021

@knadh @mr-karan so can I just confirm that, despite this ticket being closed, there still isn't the possibility to add a custom s3-compatible provider in listmonk?
That is to say, there is no means via the UI or via environment variable to change the base (hard-coded) amazon url string to another custom one like minio?

@knadh
Copy link
Owner

knadh commented Jul 8, 2021

Thanks for bringing this up @c-nv-s. This was missed. Will add the backend URL as a configurable field on the S3 settings UI in the upcoming version.

@knadh knadh reopened this Jul 8, 2021
@knadh knadh self-assigned this Jul 8, 2021
@knadh knadh closed this as completed in d6d1883 Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants