Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0 #1039

Closed
knadh opened this issue Nov 18, 2022 · 13 comments
Closed

v2.3.0 #1039

knadh opened this issue Nov 18, 2022 · 13 comments
Labels
todo To-do in the immediate / short term

Comments

@knadh
Copy link
Owner

knadh commented Nov 18, 2022

v2.3.0 is ready barring a few minor things which I'll add over the next couple of days. Have been testing in a large production system over the last two weeks.

Tagging i18n language contributors. Like last time, there are a few new strings in the English file that aren't in the other files. Would be great if you'd be able to find time to compare and submit any changes before the next release. You can either pull the repo and do a diff, or use this UI to easily spot the changed strings and translate. It gives you a language JSON file which you can send as a PR: https://listmonk.app/i18n/

Thanks!

Pending


Completed

@knadh knadh added the todo To-do in the immediate / short term label Nov 18, 2022
@knadh knadh pinned this issue Nov 18, 2022
@t3hmrman
Copy link
Contributor

t3hmrman commented Nov 19, 2022

PR ready for review!

I couldn't find much context around campaigns.testDisabled -- is that supposed to be something like Disabled <X> (ex. Disabled User) in context? Can't find it used in the codebase either.

@knadh
Copy link
Owner Author

knadh commented Nov 19, 2022

Thanks @t3hmrman! Looks like that's a stray string. Will remove.

@NicoHood
Copy link
Contributor

Is there a way to only show the untranslated strings?

@knadh
Copy link
Owner Author

knadh commented Nov 20, 2022

Yep. https://listmonk.app/i18n/

image

@NicoHood
Copy link
Contributor

Nice!

It would be nice if someone can double-check: #1045

This link is broken by the way:
image

@knadh
Copy link
Owner Author

knadh commented Nov 23, 2022

Planning the release on Saturday. Would be great if could look at the pending languages before that. There are only about 10-15 new strings to translate. Thank you!

@NicoHood
Copy link
Contributor

Deutsch/German is finished, right? You might want to update the list above

davidesteve added a commit to davidesteve/listmonk that referenced this issue Nov 25, 2022
Update Catalan version for v2.3.0 knadh#1039
knadh pushed a commit that referenced this issue Nov 25, 2022
Update Catalan version for v2.3.0 #1039
@mannm123
Copy link
Contributor

mannm123 commented Nov 25, 2022 via email

@knadh
Copy link
Owner Author

knadh commented Nov 25, 2022

The new version has some words that need me to translate into my language?

Yep.

@Martianovas
Copy link

Martianovas commented Nov 27, 2022

Hallo zusammen! Hello everybody!

Please help me, "make dist to build the listmonk binary. " make dist - what is it? i work in windows os.
How to bulild .exe from distr?

for example in Goland ???
https://drive.google.com/file/d/1BYuui9kGa6PtzvXvusAGiZSXTuKGSaCo/view?usp=sharing

Best regards,
Sergey

@knadh
Copy link
Owner Author

knadh commented Nov 27, 2022

Hi @Martianovas. Please open a separate issue if you've questions unrelated to the v2.3.0 release.

I'm unfamiliar with the Windows environment and Golang. That said, you needn't compile the program on Windows. You can download the pre-compiled binary here: https://github.com/knadh/listmonk/releases/download/v2.2.0/listmonk_2.2.0_windows_amd64.tar.gz

@mannm123
Copy link
Contributor

mannm123 commented Nov 27, 2022 via email

@knadh
Copy link
Owner Author

knadh commented Nov 27, 2022

v2.3.0 is released. Thanks everyone.

@knadh knadh closed this as completed Nov 27, 2022
@knadh knadh unpinned this issue Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo To-do in the immediate / short term
Projects
None yet
Development

No branches or pull requests

5 participants