Remove unnecessary paren #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
どちらでも大丈夫です。どちらかと言えば新しい別のテストケースとして足してもらった方がうれしいかな、くらいの感じです。 |
|
新しいテストケースを追加しました。 |
|
(trailing newline について、pre-commit を設定してるのに直されず CI でも落ちないならもう完全にリポジトリ側の責任です。ごめんね) |
|
テストの追加ありがとう。ちゃんと直ってるみたいなのでマージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #130
添字の式は Jikka/CPlusPlus/Format.hsのreturnで返す値部分 と近いと考えてこれを参考に変更しました。
テストを加えたいです。そこで、test/Jikka/CPlusPlus/FormatSpec.hs にテストケースを追加するか、もしくは既存のテストケースに添え字を使うように変更をいれるか迷っています。どちらがよいでしょうか。