Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.1; use YAML.safe_load(_file) #1767

Merged
merged 7 commits into from
Jan 5, 2022
Merged

Support Ruby 3.1; use YAML.safe_load(_file) #1767

merged 7 commits into from
Jan 5, 2022

Conversation

takahashim
Copy link
Collaborator

@takahashim takahashim commented Dec 28, 2021

Psych should be >= 3.3.2 (see ttps://www.ruby-lang.org/en/news/2021/12/25/ruby-3-1-0-released/ )

#1766 の対応です。

  • Pyschを3.3.2に固定(4.xだと古い環境のツールが動かなくなるようなので。具体的にはgemコマンドでエラーが出るようになった)
  • YAML.load_file(path)YAML.safe_load_file(path, aliases: true, permitted_classes: [Date])に変更
  • Rubocopでエラーが出るところがあったので一部修正したりRubocopのルールを変更したりした

This was referenced Dec 29, 2021
@takahashim takahashim mentioned this pull request Jan 5, 2022
@takahashim takahashim merged commit f4fc64a into master Jan 5, 2022
@takahashim takahashim deleted the fix-psych-4 branch January 5, 2022 06:18
@kmuto
Copy link
Owner

kmuto commented Jan 6, 2022

@takahashim
おっと。bundler経由だと動いても、手元で実行してなかったです…。
Debian stable・gemなしのOS提供ruby 2.7.4 で壊れました。

@kmuto kmuto mentioned this pull request Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants