Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): allow all extension array data types in pandas adapters #1

Open
wants to merge 18 commits into
base: any-time-resolution-2
Choose a base branch
from

Conversation

ilan-gold
Copy link

@ilan-gold ilan-gold commented Oct 23, 2024

This probably needs some work, but since pandas datetime handling often goes through extension arrays, I think these two issues are completely linked

cc: @shoyer @kmuehlbauer

@ilan-gold
Copy link
Author

It's tough to do this without CI - I will push a few of the sorts of things re: datetimes that will change so you get a sense, but generally, things are even cleaner (more datetimes preserved).

@ilan-gold
Copy link
Author

Not sure we want to keep allowing pandas in-memory date time stuff + dask: 59b03f2 maybe should start blanket converting extension arrays before dask?

@ilan-gold ilan-gold force-pushed the ig/fix_extension_indexer branch from a9c9386 to 7c32bd0 Compare October 24, 2024 07:25
@kmuehlbauer kmuehlbauer reopened this Oct 24, 2024
@kmuehlbauer
Copy link
Owner

@ilan-gold Tried to activate CI, but seems it doesn't work. I'm back to desk next week, won't have time to check this now.

@shoyer
Copy link

shoyer commented Oct 24, 2024

Can you open this up as a pull request against pydata/xarray?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants