Skip to content

Commit

Permalink
Fix ClusterMetadata detector
Browse files Browse the repository at this point in the history
Signed-off-by: Tamal Saha <[email protected]>
  • Loading branch information
tamalsaha committed Jun 12, 2024
1 parent 3c1fd4e commit 3b50965
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 10 deletions.
12 changes: 7 additions & 5 deletions cluster/lib.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
cu "kmodules.xyz/client-go/client"

core "k8s.io/api/core/v1"
kerr "k8s.io/apimachinery/pkg/api/errors"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
Expand All @@ -48,12 +49,13 @@ func ClusterUID(c client.Reader) (string, error) {
func ClusterMetadata(c client.Reader) (*kmapi.ClusterMetadata, error) {
var cm core.ConfigMap
err := c.Get(context.TODO(), client.ObjectKey{Name: kmapi.AceInfoConfigMapName, Namespace: metav1.NamespacePublic}, &cm)
if err != nil {
return nil, err
}
result, err := ClusterMetadataForConfigMap(&cm)
if err == nil {
return result, nil
result, err := ClusterMetadataForConfigMap(&cm)
if err == nil {
return result, nil
}
} else if !kerr.IsNotFound(err) {
return nil, err
}

var ns core.Namespace
Expand Down
12 changes: 7 additions & 5 deletions tools/clusterid/lib.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
kmapi "kmodules.xyz/client-go/api/v1"
clustermeta "kmodules.xyz/client-go/cluster"

kerr "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes"
corev1 "k8s.io/client-go/kubernetes/typed/core/v1"
Expand All @@ -37,12 +38,13 @@ func ClusterUID(client corev1.NamespaceInterface) (string, error) {

func ClusterMetadata(client kubernetes.Interface) (*kmapi.ClusterMetadata, error) {
cm, err := client.CoreV1().ConfigMaps(metav1.NamespacePublic).Get(context.TODO(), kmapi.AceInfoConfigMapName, metav1.GetOptions{})
if err != nil {
return nil, err
}
result, err := clustermeta.ClusterMetadataForConfigMap(cm)
if err == nil {
return result, nil
result, err := clustermeta.ClusterMetadataForConfigMap(cm)
if err == nil {
return result, nil
}
} else if !kerr.IsNotFound(err) {
return nil, err
}

ns, err := client.CoreV1().Namespaces().Get(context.TODO(), metav1.NamespaceSystem, metav1.GetOptions{})
Expand Down

0 comments on commit 3b50965

Please sign in to comment.