Add xarray backend for Igor Pro files #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.pxt`, `.pxp`, and `.ibw` files can now be opened with xarray methods such as `xr.open_dataset` and `xr.open_dataarray`. See the updated user guide for more information.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 75.94% 77.46% +1.51%
==========================================
Files 64 66 +2
Lines 10543 10697 +154
==========================================
+ Hits 8007 8286 +279
+ Misses 2536 2411 -125 ☔ View full report in Codecov by Sentry. |
Calling `erlab.io.load_wave` and `erlab.io.load_experiment` is deprecated. When writing new code, use `xarray.load_dataarray` and `xarray.load_dataset` instead.
Whenever the `identify()` method failed to find any files, subclasses had to explicitly raise `FileNotFoundError`. This resulted in a lot of boilerplate code and ambiguous error messages. Now, all subclasses can just return `None` in `identify()` when no files are found. The appropriate error is automatically raised.
Memmapping seemed to interfere loading multiple files when called through ipywidgets.
kmnhan
force-pushed
the
dev-io
branch
5 times, most recently
from
4141c42 to
08930bb
Compare
When accessing the data of a single slice from the right-click menu of `ImageTool`, the attributes of the original data are now kept. This allows saved slices or data opened in other tools to retain their attributes.
This commit adds a new data loader for beamline ID21 ESM at NSLS-II, Brookhaven National Laboratory.
The DA30 loader now tries to return a dataset from `.zip` files only when there are no coordinate conflicts. In the case of conflicts, the loader will return a `DataTree`. Also, single region DA30 `.pxt` files will now return a `DataArray` consistent with the equivalent `.ibw` file.
Coordinate order was broken for loaders which assign coordinates in inherited `post_process`. This is now fixed, and returned data will be consistently ordered with respect to the mapping, with the dimension coordinates coming first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a backend so that igor pro files (.pxp, .pxt, .ibw) can be opened with
xr.open_dataarrayandxr.open_dataset.Links:
https://docs.xarray.dev/en/stable/internals/how-to-add-new-backend.html
Change io functions to use xarray methods likexr.open_mfdatasetAfter testing with dask, joblib-based parallelization seems to work better (at least for igor files)
Update documentation with changes to data loaderPostpone change to 3.0
Drop support returning list of items, it was prone to breaking anyways, replace withDataTreeThis breaks too many things, better split