Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 fixes section header showing underneath breadcrumbs header #4

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

zsinnema
Copy link
Contributor

No description provided.

Copy link
Owner

@kmantel kmantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue shows up in several other places with different levels of nested section tags. Some examples which would be missed by article > section > section:
https://princetonuniversity.github.io/PsyNeuLink/Composition.html#composition
https://princetonuniversity.github.io/PsyNeuLink/Composition.html#graph
I think just section would be ok for this.

There are also some screen-size-aware rules for psyneulink-page-level-bar that cause this problem not to occur on some screen sizes, so it would be good to handle these cases also, to avoid extra whitespace.
See
https://github.com/kmantel/psyneulink-sphinx-theme/blob/622332fe9cf3173f1ba910ead8707c372e552fc9/psyneulink_sphinx_theme/static/css/theme.css#L10874-L10916=

@zsinnema zsinnema marked this pull request as draft June 3, 2022 07:46
@zsinnema zsinnema marked this pull request as ready for review June 3, 2022 08:08
@zsinnema
Copy link
Contributor Author

zsinnema commented Jun 3, 2022

@kmantel yes I think it can be set on just section. See my last commit. I also wrapped it in a @media query to only apply when screen sizes > 1100px.

@zsinnema zsinnema requested a review from kmantel June 3, 2022 08:10
Copy link
Owner

@kmantel kmantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants