Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pip installable wheels #921

Closed
4 tasks done
hroncok opened this issue Mar 23, 2018 · 12 comments
Closed
4 tasks done

Make pip installable wheels #921

hroncok opened this issue Mar 23, 2018 · 12 comments

Comments

@hroncok
Copy link
Collaborator

hroncok commented Mar 23, 2018

I'll do this. After 2.0.0 final is released.

  • setup.py looks like a mess, let's clean it first
  • requirements are in requirements.txt only, move to (or dynamically load them from) setup.py install_requires
  • make wheels buildable, test them
  • possibly CI the wheels creation if @kliment agrees 😄
@setherith
Copy link

I'm currently struggling like crazy on installing on Linux Mint 18 (x64). I went with the virtual environment approach as suggested but getting "Segmentation fault" when I start it. Please keep me updated on any changes to the install process for my OS, and if I can help in anyway I'll be glad to lend a hand 👍

@hroncok
Copy link
Collaborator Author

hroncok commented Jul 16, 2020

I'll try to look at this again this weekend.

@hroncok
Copy link
Collaborator Author

hroncok commented Jul 20, 2020

I didn't make it, because I was offline all weekend, but it still si on my TODO.

hroncok added a commit to hroncok/Printrun that referenced this issue Jul 24, 2020
hroncok added a commit to hroncok/Printrun that referenced this issue Jul 24, 2020
hroncok added a commit to hroncok/Printrun that referenced this issue Jul 24, 2020
Related to kliment#921

This makes it possible to build sdists and wheels on Linux at least.

Unfortunately dbus-python and wxPython have no Linux wheels,
but otherwise the wheel is pip installable.
hroncok added a commit to hroncok/Printrun that referenced this issue Jul 24, 2020
Related to kliment#921

This makes it possible to build sdists and wheels on Linux at least.

Unfortunately dbus-python and wxPython have no Linux wheels,
but otherwise the wheel is pip installable.
@hroncok
Copy link
Collaborator Author

hroncok commented Jul 24, 2020

I've opened #1078 as step one.

If somebody could build and install the wheel on other platforms, that would be cool.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 2, 2020

#1082 fixed the rest, but Ḯll close this once we have wheels on PyPI.

@kliment
Copy link
Owner

kliment commented Aug 29, 2020

Something is wrong with the wheels we're generating - when I install them with pip I can't run the application - it fails to find the ui image resources and crashes on startup. Pronsole seems to work. On macOS, it's even worse - the application fails to start, with the same error, but then instead of exiting just gets stuck forever until manually stopped. I'm not sure what's happening there, the images get installed to (venvpath)/share/pronterface/*.png but the application is looking for them in images/*.png

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 29, 2020

I'll have a look next week.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 29, 2020

def imagefile(filename):
for prefix in ['/usr/local/share/pronterface/images',
'/usr/share/pronterface/images']:
candidate = os.path.join(prefix, filename)
if os.path.exists(candidate):
return candidate

This (and other such constructs in the file) makes it so.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 29, 2020

I believe we need to replace /usr (and /usr/local) with sys.prefix here. That should be venv agnostic.

@hroncok
Copy link
Collaborator Author

hroncok commented Aug 31, 2020

@kliment please test from #1101

@kliment
Copy link
Owner

kliment commented Sep 5, 2020

I tried the wheel that the CI built for #1101 and it fails at 'self.bg_bmp = wx.Image(imagefile(self.imagename), wx.BITMAP_TYPE_PNG).ConvertToBitmap()' in printrun/gui/xybuttons.py which expects to find a file in "images/control_xy.png" but the file is actually in sys.prefix+share/pronterface/control_xy.png so we're still losing a directory somewhere

@kliment kliment closed this as completed in bf9e237 Sep 6, 2020
@kliment
Copy link
Owner

kliment commented Sep 6, 2020

We now have wheels on PyPI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants