Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set up notifications (using hardware wallet) #32

Closed
PresenceNumerique opened this issue Feb 4, 2020 · 3 comments
Closed

Unable to set up notifications (using hardware wallet) #32

PresenceNumerique opened this issue Feb 4, 2020 · 3 comments

Comments

@PresenceNumerique
Copy link

When trying to set up notifications, my hardware wallet is not triggered and i can't sign.
image
Thus resulting in this error :
image

I am using a ledger nano x with Brave.

@eccentricexit
Copy link
Contributor

eccentricexit commented May 22, 2020

The commit message that closed this was incorrect. It closes issue #34 instead.

@clesaege
Copy link
Member

So I tried with a ledger and got the same issue. Signing messages like in the court works. But here it seems you are using some advanced message functionality with parameters. I guess that is what is causing the issues.

@eccentricexit
Copy link
Contributor

Unfortunately this is related to ledger itself and it seems that it won't be fixed soon:

https://www.reddit.com/r/ledgerwallet/comments/gcdx1f/any_hope_for_eip712_support/
MetaMask/metamask-extension#5050 (comment)

In the meantime we'll have to revert to using legacy signing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants