Error on missing inject tags, Twig support #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, I'll set up testing env and see why this is failing :/ |
|
The tests are failing because of the exception being thrown when there aren't tags, so you just need to make sure to catch the exception in the unit tests. |
|
Merged the twig spport by hand, will be looking at adding the other code and updating the tests. thx @spinx |
|
Way to much changed since August 2015 for me to see if the rest of the PR still is needed at all and if yeshow it could be added. Any comments @joakimbeng ? |
This was referenced Jun 4, 2019
1 task
1 task
This was referenced Oct 1, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a silent fail if inject tags are malformed or missing.
Also added Twig support.