Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High vulnerability from set-value #261

Closed
TheoMugnier opened this issue Jul 22, 2019 · 2 comments · Fixed by #262
Closed

High vulnerability from set-value #261

TheoMugnier opened this issue Jul 22, 2019 · 2 comments · Fixed by #262
Labels

Comments

@TheoMugnier
Copy link

TheoMugnier commented Jul 22, 2019

🚫Pinning group array to 0.3.3 lead to a high vulnerability ! 🚫
So this can't be considered a permanent fix (Fixed in 0.3.4 of group-array)
(Merged PR: #258)

From npm audit security report :

High : Prototype Pollution
Package : set-value
Patched in : >=2.0.1 <3.0.0 || >=3.0.1
Dependency of : gulp-inject
Path : gulp-inject > group-array > union-value > set-value
More info : https://npmjs.com/advisories/1012

@joakimbeng
Copy link
Member

🎉 This issue has been resolved in version 5.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

tiberiuzuld pushed a commit to tiberiuzuld/gulp-inject that referenced this issue Jul 23, 2019
@yeaske
Copy link

yeaske commented Jul 26, 2019

Just an FYI as I'm not sure if the version I'm using is deprecated.
I am using [email protected] and in the latest npm install it replaced [email protected] with [email protected]. ["group-array": "^0.3.0"].
This has caused the src stream consumption in inject to fail as it just takes the last element of the stream. I was able to fix this by moving back to [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants