Skip to content
This repository has been archived by the owner on Jun 2, 2020. It is now read-only.

The wrong type for "refunds" is used in the "OrderManagementOrder" class #57

Closed
alexions opened this issue Aug 8, 2019 · 3 comments
Closed
Assignees

Comments

@alexions
Copy link
Contributor

alexions commented Aug 8, 2019

we are using the .NET library and we found a bug:
In the class "OrderManagementOrder" the wrong type for "refunds" is used.

It should be like that:

/// </summary>
[JsonProperty(PropertyName = "refunds")]
public ICollection<OrderManagementGetRefundResponse> Refunds { get; set; }
@alexions alexions self-assigned this Aug 8, 2019
@alexions
Copy link
Contributor Author

alexions commented Aug 8, 2019

The PR is in the code-review, feel free to comment.

The initial issue:
For some reason we have 2 similar Refund models: OrderManagementRefund and OrderManagementGetRefundResponse. By fact - these two models are the same (based on the original documentation).

Ideal fix: Actualize one of the model and use it everywhere.
Real fix: In order to keep the backward compatibility I kept both of the models, but now the OrderManagementGetRefundResponse just inherits the OrderManagementRefund with no changes. Let's say - they are the same.

I actualized the OrderManagementRefund and put all the fields specified in the documentation.

So the issue must be fixed now.

@Marc19801
Copy link

Tank you for the very fast fix!!!

alexions pushed a commit that referenced this issue Aug 8, 2019
Fix #57: Combine similar OrderManager Refund models into a single one.
@alexions
Copy link
Contributor Author

alexions commented Aug 9, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants