Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode nil as null #92

Merged
merged 3 commits into from
Jan 31, 2020
Merged

Encode nil as null #92

merged 3 commits into from
Jan 31, 2020

Conversation

davydog187
Copy link
Contributor

@davydog187 davydog187 commented Jan 28, 2020 •
edited
Loading

Fixes the encoding part of #91. I'll open another for the decoding

This is admittedly my first Erlang code ever, so I may have botched something.

@coveralls
Copy link

coveralls commented Jan 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 574

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 566: 0.0%
Covered Lines: 1703
Relevant Lines: 1703
💛 - Coveralls

@davydog187 davydog187 mentioned this pull request Jan 29, 2020
Closed
@davydog187
Copy link
Contributor Author

@zmstone do you have any feedback on this PR?

@zmstone
Copy link
Contributor

zmstone commented Jan 30, 2020

Look good to me.
ping @mikpe @qzhuyan @k32 for approval and merge.

@zmstone
Copy link
Contributor

zmstone commented Jan 30, 2020

oh, maybe update changelog.md and bump a minor.

@davydog187
Copy link
Contributor Author

@zmstone I bumped the patch version and added to changelog.

CC: @mikpe @qzhuyan @k32 for review/approval

mikpe
mikpe approved these changes Jan 31, 2020
View reviewed changes
src/avro_primitive.erl Show resolved Hide resolved
@davydog187 davydog187 mentioned this pull request Jan 31, 2020
Closed
@davydog187
Copy link
Contributor Author

@mikpe looks like you need to merge for me :)

Would it be possible to do a release as well?

@mikpe mikpe merged commit ebdee67 into klarna:master Jan 31, 2020
@mikpe
Copy link
Member

mikpe commented Jan 31, 2020

Merged and tagged.

This was referenced Jan 31, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikpe mikpe mikpe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davydog187 @coveralls @zmstone @mikpe