fix:primefaces#6987 Dropdown filter freezes screen

kl-nevermore · Aug 6, 2024 · 3d327db · 3d327db
1 parent 0de1b70
commit 3d327db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/components/lib/dropdown/Dropdown.js b/components/lib/dropdown/Dropdown.js
@@ -989,6 +989,10 @@ export const Dropdown = React.memo(
             }
         }, [overlayVisibleState, filterState, props.filter]);
 
+        useUpdateEffect(() => {
+            virtualScrollerRef.current && virtualScrollerRef.current.scrollInView(0);
+        }, [filterState]);
+
         useUpdateEffect(() => {
             if (filterState && (!props.options || props.options.length === 0)) {
                 setFilterState('');

diff --git a/components/lib/dropdown/DropdownPanel.js b/components/lib/dropdown/DropdownPanel.js
@@ -50,7 +50,6 @@ export const DropdownPanel = React.memo(
         };
 
         const onFilterInputChange = (event) => {
-            props.virtualScrollerRef.current && props.virtualScrollerRef.current.scrollToIndex(0);
             props.onFilterInputChange && props.onFilterInputChange(event);
         };
-Original file line number
+Diff line change
@@ Expand Up / @@ -50,7 +50,6 @@ export const DropdownPanel = React.memo( @@
             };
             const onFilterInputChange = (event) => {
-                props.virtualScrollerRef.current && props.virtualScrollerRef.current.scrollToIndex(0);
                 props.onFilterInputChange && props.onFilterInputChange(event);
             };
@@ Expand Down @@