Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: remove logging perf of coverage in main #673

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

Eikix
Copy link
Member

@Eikix Eikix commented Feb 6, 2025

le logger de perf de coverage rend la nightly trop verbose
je recommande de supprimer les log info dans le coverage

@enitrat
Copy link
Collaborator

enitrat commented Feb 6, 2025

make it debug level?

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make it debug

@Eikix
Copy link
Member Author

Eikix commented Feb 6, 2025

ok will set nightly in info and ths in debug

@Eikix
Copy link
Member Author

Eikix commented Feb 6, 2025

change into logging total coverage time once

Copy link
Member

@ClementWalter ClementWalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is far from any prio, I wouldn't mind either just putting debug to the logger as discussed earlier, of remove this logger, but no accumulation like that

@Eikix
Copy link
Member Author

Eikix commented Feb 6, 2025

since this is far from any prio, I wouldn't mind either just putting debug to the logger as discussed earlier, of remove this logger, but no accumulation like that

ok i vote to remove it then, it's so verbose it's unreadable
if we need it we can profile the coverage

@ClementWalter ClementWalter merged commit 6b3670b into main Feb 6, 2025
3 checks passed
@ClementWalter ClementWalter deleted the fix/coverage_log branch February 6, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants