feat: _prepare_trie #654
Merged
feat: _prepare_trie #654
+664
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
force-pushed
the
feat/prepare-trie
branch
2 times, most recently
from
3bf07bb to
85c63d0
Compare
|
to be rebased and then will be ready for review |
enitrat
force-pushed
the
feat/prepare-trie
branch
2 times, most recently
from
044fc03 to
85bb42c
Compare
enitrat
requested review from
ClementWalter,
Eikix and
obatirou
and removed request for
ClementWalter and
Eikix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
==========================================
+ Coverage 82.09% 82.48% +0.38%
==========================================
Files 56 56
Lines 12227 12558 +331
==========================================
+ Hits 10038 10358 +320
- Misses 2189 2200 +11 ☔ View full report in Codecov by Sentry. |
enitrat
force-pushed
the
feat/prepare-trie
branch
2 times, most recently
from
4ffd081 to
b9dd53a
Compare
enitrat
requested review from
ClementWalter,
Eikix and
obatirou
and removed request for
ClementWalter and
obatirou
enitrat
force-pushed
the
feat/prepare-trie
branch
from
73c8e77 to
be24996
Compare
Merged
obatirou
reviewed
Feb 10, 2025
obatirou
reviewed
Feb 10, 2025
obatirou
reviewed
Feb 10, 2025
|
add the required cases for 100% coverage |
|
also, I think that the eels trie as it is (with the secure param) eventually makes us hash several time the same node, tbc |
enitrat
force-pushed
the
feat/prepare-trie
branch
from
e65efb8 to
ec3fe92
Compare
obatirou
approved these changes
Feb 11, 2025
ClementWalter
added a commit
that referenced
this pull request
Feb 11, 2025
depends on #654 closes #649 --------- Co-authored-by: Clément Walter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #636
note: this is using the storage_tries as Trie[Bytes32, U256]. At some point we will need to re-build this trie in Cairo from the Trie[Tuple[Address, Bytes32], U256].
We need to scope an issue on how to go from our internal representation to a storage trie per account. This likely goes in the state root epic