Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make configurable via environment variables #7

Merged
merged 3 commits into from
May 16, 2021
Merged

Make configurable via environment variables #7

merged 3 commits into from
May 16, 2021

Conversation

andrewcole
Copy link
Contributor

Adds the option to pass the configuration flags via environment variables.

kkosmrli
kkosmrli requested changes May 15, 2021
View reviewed changes
Copy link
Owner

@kkosmrli kkosmrli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I like the env option a lot, good idea 👍 Did not know go-arg before but it looks good and seems slim enough.

We just have some conflicts after the recent changes.

cmd/leader-elector/main.go Outdated Show resolved Hide resolved
@andrewcole andrewcole requested a review from kkosmrli May 16, 2021 02:45
@andrewcole
Copy link
Contributor Author

Rebased to latest master, updated changes to include environment variables for new config options.

kkosmrli
kkosmrli approved these changes May 16, 2021
View reviewed changes
Copy link
Owner

@kkosmrli kkosmrli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 🥇

@kkosmrli kkosmrli merged commit 14ad36b into kkosmrli:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkosmrli kkosmrli kkosmrli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewcole @kkosmrli