-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parametrize Editor by the Completer type #52
Conversation
Happy to update this PR if you find any problems with it. It may be a bit awkward that users need to explicitly parametrize |
Hey @Marwes, sorry that I didn't get back to you on your issue during the week. I agree that with you that it is a bit awkward with explicitly parametrizing Editor if there is no completer but I am okay with it. Can you update the README.md example to reflect that change? I also just merged in another branch into master and it has caused some conflicts with your branch. |
043cc38
to
83664d9
Compare
This allows the `Editor` to implement `Sync` as long as it contains a completer which implement `Sync`. It lets the `Editor` take ownership of the completer.
83664d9
to
8c98597
Compare
No problem I am in no rush, just wanted to make sure making the change was possible. A tip for keeping the README example updated, skeptic is really useful to ensure that the examples in the README always builds (though it can be a bit slow if you start having 10+ examples as I have found). |
👍 |
@kkawakam note to self: indicate in release notes this is a breaking change because of the need to explicitly parametrize the Editor when there is no completer. |
@kkawakam I used the pattern of I obviously don't mind |
Fix generated bindings
This allows the
Editor
to implementSync
as long as it contains a completer which implementSync
. It lets theEditor
take ownership of the completer.Fixes #49