fix for encode_ut8 returning iterator #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thank you. I'll be pushing out a new version of rustyline tonight |
|
Pushed 0.2.2 to crates.io |
|
Actually, when trying to use this now, it seems to be failing with an EOF error every time now. I can't tell for sure if this is from my change, but it seems likely. I unfortunately don't have any time to delve into it right now, but hopefully I will later tonight/tomorrow. Sorry about the hassle! |
|
Thanks for taking a look. I'll try to take a look tonight as well. |
gwenn
pushed a commit
to gwenn/rustyline
that referenced
this pull request
Nov 30, 2018
Use `std::ptr::Unique` to ensure SqliteConnection is Send.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest nightly changes
str::char::encode_utf8takes no arguments and returns an iterator instead of returning a size and taking in a mutable buffer.