forked from project-chip/connectedhomeip
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Splitted building with Matter OTA and DFU over SMP #56
Open
kkasperczyk-no
wants to merge
3
commits into
master
Choose a base branch
from
dfu_configuration_refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkasperczyk-no
requested review from
LuDuda,
doublemis1,
Damian-Nordic and
wiba-nordic
January 20, 2022 11:06
Currently when enabling Matter OTA DFU, the another DFU over Bluetooth LE using SMP configuration is also enabled. It should be available to enable independently. * Enabled Matter OTA by default for lighting-app * Modified cmake BUILD_WITH_DFU option to allow disabling DFU support, enabling Matter OTA DFU and enabling Matter OTA DFU + DFU over Bluetooth LE * Splitted config overlays to extract common DFU parts from SMP specific ones. * Updated examples documentation
kkasperczyk-no
force-pushed
the
dfu_configuration_refactor
branch
from
January 20, 2022 11:11
4f49760
to
6029a0e
Compare
wiba-nordic
requested changes
Jan 20, 2022
wiba-nordic
approved these changes
Jan 25, 2022
Damian-Nordic
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently when enabling Matter OTA DFU, the another DFU over
Bluetooth LE using SMP configuration is also enabled. It should
be available to enable independently.
Change overview
support, enabling Matter OTA DFU and enabling Matter OTA DFU
from SMP specific ones.