[icd] Removed ICD related methods (former SED) from NoThreadImpl #145
Conversation
kkasperczyk-no
requested review from
Damian-Nordic,
ArekBalysNordic and
markaj-nordic
| #if CHIP_DEVICE_CONFIG_ENABLE_SED | ||
| CHIP_ERROR ConnectivityManagerImplWiFi::_GetSEDIntervalsConfig(ConnectivityManager::SEDIntervalsConfig & SEDIntervalsConfig) | ||
| { | ||
| // Wi-Fi uses legacy power save mode that has fixed inactivity interval |
There was a problem hiding this comment.
The interval is actually AP-controlled. We use constants just because we don't have an API for that yet.
There was a problem hiding this comment.
Right, I mean, that the intervals for our Wi-Fi platform are fixed and cannot be changed dynamically, like for Thread.
There was a problem hiding this comment.
It will be possible with the anticipated Wi-Fi net_mgmt API extensions. Then we will implement the method for getting these values in the WiFiManager.
There was a problem hiding this comment.
Ok, I added "for now" to the comment then :)
| #if CHIP_DEVICE_CONFIG_ENABLE_SED | ||
| CHIP_ERROR ConnectivityManagerImplWiFi::_GetSEDIntervalsConfig(ConnectivityManager::SEDIntervalsConfig & SEDIntervalsConfig) | ||
| { | ||
| // Wi-Fi uses legacy power save mode that has fixed inactivity interval |
There was a problem hiding this comment.
It will be possible with the anticipated Wi-Fi net_mgmt API extensions. Then we will implement the method for getting these values in the WiFiManager.
kkasperczyk-no
force-pushed
the
sed_intervals_wifi
branch
3 times, most recently
from
2044552 to
d4c1add
Compare
There are several methods related to ICD (former SED) used for setting expected communication intervals. Currently they are implemented only for Thread devices and for Wi-Fi the implementation returns unsupported feature through NoThreadImpl. Including this sleep intervals could be useful for some low power Wi-Fi modes too. Changes: * Removed methods implementation from NoThread impl. Now after enabling CHIP_DEVICE_CONFIG_ENABLE_SED (I believe it should be renamed to ICD in the future), the implementation will have to be provided by the proper platform. * Implemented methods for nrfconnect Wi-Fi platform.
kkasperczyk-no
force-pushed
the
sed_intervals_wifi
branch
from
d4c1add to
46a79b8
Compare
There are several methods related to ICD (former SED) used for setting expected communication intervals. Currently they are implemented only for Thread devices and for Wi-Fi the implementation returns unsupported feature through NoThreadImpl. Including this sleep intervals could be useful for some low power Wi-Fi modes too.
Changes: