AWS S3 adapter using the bare aws-sdk gem #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternate adapter to the S3Adapter for those using the plain old bare 'aws-sdk' gem without 'fog'. This class modelled on that adapter but also sets up the S3 object to return the following additional HTTP headers: * Cache-Control: private, max-age=0, no-cache * Content-Type: application/x-gzip for completeness. No integration test created, as noted in the s3_adapter_spec.rb, it would be of limited use. IAM authentication is not yet supported.
|
Thanks for sharing this. Fog's long list of dependencies made the official aws gem a better choice for us. Why was this not merged? |
|
I just successfully deployed this to production 🙈 |
|
Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternate adapter to the S3Adapter for those using the plain old
bare 'aws-sdk' gem without 'fog'. This class modelled on that adapter
but also sets up the S3 object to return the following additional HTTP
headers:
for completeness.
No integration test created, as noted in the s3_adapter_spec.rb, it
would be of limited use.
IAM authentication is not yet supported.