Allows more flexible scanning #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch uses the BleakScanner interface to simplify the scanning as well as provide more means of connecting. With an address, a BLEDevice, or with a user provided scanner. This change will allow me to implement a Home Assistant integration using [Bluetooth discovery](https://developers.home-assistant.io/docs/network_discovery/#best-practices-for-library-authors). Other changes: `black`
ViViDboarder
force-pushed
the
more-flexible-scanning
branch
from
4bc845c to
0362803
Compare
The `PyHatchBabyRestAsync` constructor has been updated to allow running from another async coroutine. This is done by providing constructor options to skip any async calls within teh constructor and make those via a future method called on the constructed object. A helper function and example has been created to make this easier.
ViViDboarder
force-pushed
the
more-flexible-scanning
branch
from
be18231 to
ffaa2dd
Compare
|
It's worth noting that
In the future when it does become an alias, it will fail to run if there is no running loop. At that point, using the async helper created here will work but other refactoring may be required to maintain current status quo. |
This was referenced Aug 26, 2022
kjoconnor
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses the BleakScanner interface to simplify the scanning as
well as provide more means of connecting. With an address, a BLEDevice,
or with a user provided scanner.
This change will allow me to implement a Home Assistant integration
using Bluetooth
discovery.
Other changes:
black