Added Localization keys and null checks #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user forgets to enter text in field consent or in field textparagraph, it generates a null exception on frontend which is too much.
Vrijdagonline
changed the title
|
Hi @Vrijdagonline, Thanks for this! It's awesome 👍 and super cool you're doing translations! By all means submit at PR with the translations once they're done. I'll review your changes as soon as possible and have them merged in. |
|
Excellent 👍 I'll add the Danish translations after the merge. Thanks again! I'll publish a new release this weekend. |
|
Well to be honest this is the least I could do. You have done an amazing job with this package! I’ll do a PR when the dutch translation is ready. It needs a review first from a non technical guy 🙄 Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Kenn,
Awesome project! Good job bud!
I am in the process of translating your project in Dutch. In the process I encountered a few missing keys. So that is what this PR is.
Would you like to have the Dutch Lang file too?
Cheers,
Arjan Woldring