Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload validation #163

Closed
uniquelau opened this issue Nov 21, 2017 · 4 comments
Closed

Upload validation #163

uniquelau opened this issue Nov 21, 2017 · 4 comments

Comments

@uniquelau
Copy link
Contributor

Field, Upload, Mandatory.
Forms Editor version = 1.3.0
Umbraco version = 7.7.6

If I upload a file that exceeds the size limit, an error is displayed.

If I then select a file that passes validation, it is not uploaded and the validation message is not cleared.

This means the form cannot be submitted.

File limit is set to 1000KB, file I am trying to upload is 4000KB.

Happy to share the PDF's if that helps!

@kjac
Copy link
Owner

kjac commented Nov 22, 2017

@uniquelau hmmm.. does the form submit the second time around? And if not, which rendering are you using?

@uniquelau
Copy link
Contributor Author

uniquelau commented Nov 22, 2017 via email

@kjac
Copy link
Owner

kjac commented Nov 22, 2017 via email

kjac pushed a commit that referenced this issue Nov 26, 2017
@kjac
Copy link
Owner

kjac commented Nov 28, 2017

@uniquelau the fix for this is two-fold:

  1. The server validation errors are cleared once a new file is selected.
  2. The clientside JS now validates the selected file sizes, to avoid the problem happening in the first place (and avoid uploading large files in vain).

v1.3.1.0 is out now with this fix.

@kjac kjac closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants