Lazy loading #46
Closed
Lazy loading #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kaistinteractionlab ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jhw123
requested changes
Sep 24, 2024
|
|
||
| const onError = () => { | ||
| setImageSrc(fallbackSrc) | ||
| } | ||
|
|
||
| return <Image {...props} src={imageSrc} alt={props.alt} onError={onError} /> | ||
| return <div ref={ref}>{inView ? <Image {...props} src={imageSrc} alt={props.alt} onError={onError} /> : null}</div> |
There was a problem hiding this comment.
<Image/> from nextjs supports lazy loading. Why do we need this?
https://nextjs.org/docs/pages/api-reference/components/image#loading
Plus, switching between null (zero-size) and Image (fixed-size) will cause flickering
| @@ -127,12 +127,34 @@ const DropDownMenu = styled.div` | |||
| } | |||
| ` | |||
|
|
|||
| const HamburgerButton = styled.button` | |||
| const HamburgerButton = styled.input` | |||
There was a problem hiding this comment.
I think it should stay as a button.
| background-color: white; | ||
| border: none; | ||
| cursor: pointer; | ||
|
|
||
| & > span { |
There was a problem hiding this comment.
This is a bad pattern. I would define each stick with another styled component.
| @@ -145,9 +149,12 @@ export default function Page() { | |||
| > | |||
| <SectionTitle>{sectionName}</SectionTitle> | |||
| <SectionContent> | |||
| {publicationList[sectionName].map(pub => ( | |||
| {/* {publicationList[sectionName].map(pub => ( | |||
|
All new PRs should be merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lazy loading optimizations to People and Publications page and make slight UI tweaks according to Juho's feedback.