Adapt to new api introduced in kiwix/libkiwix#991 #633
Conversation
| } | ||
| } | ||
| return(0); | ||
| } | ||
|
|
||
| int handle_add(kiwix::Library* library, const std::string& libraryPath, | ||
| int handle_add(kiwix::LibraryPtr library, const std::string& libraryPath, |
There was a problem hiding this comment.
I think that a parameter of type kiwix::Library& is more suitable here (passing a shared_ptr suggests that it is preserved somewhere and can be accessed after the function returns).
There was a problem hiding this comment.
We pass the library to the Manager which take a LibraryPtr.
So I have keep LibraryPtr instead of kiwix::Library&.
There was a problem hiding this comment.
Since the Manager object is completely internal to handle_add() (it no longer exists when the function returns) it would be perfectly safe to convert the Library& into a non-owning shared_ptr inside the function.
mgautierfr
force-pushed
the
adapt_libkiwix_991
branch
3 times, most recently
from
13d8333
to
61055ef
Compare
mgautierfr
force-pushed
the
adapt_libkiwix_991
branch
from
61055ef
to
018df0d
Compare
|
Would be good to merge soon, it is breaking CI of many projects. |
|
The two first commits are not especially related to kiwix/likiwix#991 but it fix the CI and without them, no PR pass. It was simpler to make on PR than two PR and merge one that was broken, expecting that the other would be fixed after. |
|
This PR fixes the CI which is broken since several days now. |
@mgautierfr The only comment that I had doesn't deserve an issue. |
See kiwix/libkiwix#991 for more details