Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation improvements for macOS #1084

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

BPerlakiH
Copy link
Collaborator

@BPerlakiH BPerlakiH commented Jan 19, 2025

Fixes: #1083
Based on the PR from: #1079

FYA: jarrodmoldrich

keyboard_nav.mov

Note

The black keyboard is not part of the application, just meant to showcase which buttons were pressed, while navigating around.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 103 lines in your changes missing coverage. Please review.

Project coverage is 36.78%. Comparing base (0712e69) to head (ea7a4a1).

Files with missing lines Patch % Lines
Views/SearchResults.swift 0.00% 43 Missing ⚠️
Views/ViewModifiers/Focusable.swift 0.00% 27 Missing ⚠️
Views/ViewModifiers/MoveCommand.swift 0.00% 17 Missing ⚠️
Views/ViewModifiers/KeyPressHandler.swift 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
- Coverage   37.21%   36.78%   -0.43%     
==========================================
  Files         129      132       +3     
  Lines        7542     7630      +88     
==========================================
  Hits         2807     2807              
- Misses       4735     4823      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BPerlakiH BPerlakiH force-pushed the keyboard-navigation branch from 5efa74b to ea7a4a1 Compare January 23, 2025 08:23
@kelson42 kelson42 merged commit 9711861 into main Jan 24, 2025
7 checks passed
@kelson42 kelson42 deleted the keyboard-navigation branch January 24, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve keyboard navigation for macOS
3 participants