Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New config option to ignore already processed resource version. #187

Merged
merged 2 commits into from
May 19, 2022

Conversation

otchilin
Copy link

@otchilin otchilin commented May 18, 2022

IGNORE_ALREADY_PROCESSED option added to filter already processed resources identified by their "resourceVersion" in metadata.
This can avoid numerous checks/logs for unchanged resources.
This feature requires kubernetes api >= v1.19.

…urceVersion metadata.

This can avoid a lot of repetitive logs about unchanged resources.
Copy link
Member

@jekkel jekkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for this contribution! I even tend to enable this by default, wdyt?

@otchilin
Copy link
Author

LGTM, thank you for this contribution! I even tend to enable this by default, wdyt?

Thanks for your feedback.
I didn't enabled it by default to avoid issues for users who may expect the default behavior in their own integration. But personally I wouldn't be shocked if it was. ;)

@jekkel jekkel added the enhancement New feature or request label May 19, 2022
@jekkel
Copy link
Member

jekkel commented May 19, 2022

Agree, let's stick with it for now. On the next major version we should think again :)

@jekkel jekkel merged commit f0d54c9 into kiwigrid:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants